this is the WIP I had when the progress commit was made.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Nothing really substantial just a couple of inline comments and...
- This kills part of the load line of SIGINFO ('load: 0.62 cmd: dd 10213 [running] 16.32r 4.08u 12.23s 80% 2592k/s") but in retrospect I don't think that's really a concern
- As someone who frequently transfers to sdcard and is certainly too lazy to do conversions manually, the extra humanized versions in the output are certainly appreciated
I'd say go for it, both to reduce diff with your work on it (given that neither the original submitter of the status=progress patch nor myself have anything else queued as you do) and for the juicy humanization.
| bin/dd/dd.c | ||
|---|---|---|
| 98 ↗ | (On Diff #46461) | C99 initializer might be preferred here, but I won't hassle you one way or the other on it. =) |
| 292 ↗ | (On Diff #46461) | This section should go away entirely. |
| bin/dd/misc.c | ||
| 60 ↗ | (On Diff #46461) | Pull this out as well |
| 114 ↗ | (On Diff #46461) | This gets thrown into .bss anyways, could drop the initialization to 0. |