Page MenuHomeFreeBSD

msdosfs: fixes for Undefined Behavior.
ClosedPublic

Authored by pfg on Aug 7 2018, 3:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 11, 2:07 AM
Unknown Object (File)
Nov 25 2024, 3:15 AM
Unknown Object (File)
Nov 24 2024, 6:15 AM
Unknown Object (File)
Nov 23 2024, 5:02 AM
Unknown Object (File)
Nov 21 2024, 2:18 AM
Unknown Object (File)
Nov 19 2024, 2:33 PM
Unknown Object (File)
Nov 9 2024, 1:46 PM
Unknown Object (File)
Nov 8 2024, 4:21 AM
Subscribers

Details

Reviewers
emaste
delphij
Summary

These were found by the Undefined Behaviour GsoC project at NetBSD:

Do not change signedness bit with left shift.
While there avoid signed integer overflow.
Address both issues with using unsigned type.

msdosfs_fat.c:512:42, left shift of 1 by 31 places cannot be represented
in type 'int'
msdosfs_fat.c:521:44, left shift of 1 by 31 places cannot be represented
in type 'int'
msdosfs_fat.c:744:14, left shift of 1 by 31 places cannot be represented
in type 'int'
msdosfs_fat.c:744:24, signed integer overflow: -2147483648 - 1 cannot be
represented in type 'int [20]'
msdosfs_fat.c:840:13, left shift of 1 by 31 places cannot be represented
in type 'int'
msdosfs_fat.c:840:36, signed integer overflow: -2147483648 - 1 cannot be
represented in type 'int [20]'

Detected with micro-UBSan in the user mode.

Hinted from: NetBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18626
Build 18315: arc lint + arc unit