Page MenuHomeFreeBSD

devel/ipython: Remove leftover artifact after removing GCC dependency
ClosedPublic

Authored by farrokhi on Aug 6 2018, 1:22 PM.

Details

Summary

Proposed commit message:

devel/ipython: Remove leftover artifact after removing GCC dependency

The ex script was supposed to add two lines in all scripts to set
LD_LIBRARY_PATH and since we don't need to set that anymore (see removed
GCC dependency in ports r476502), the whole script is now irrelevant.

#Reported by:	antoine
#Reviewed by:	koobs
#Approved by:	koobs (python)
#Differential Revision:	https://reviews.freebsd.org/D16605
Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 10-stable, 11-stable, 12-current , amd64 tested)
maketest: OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

farrokhi created this revision.Aug 6 2018, 1:22 PM
farrokhi edited the summary of this revision. (Show Details)Aug 6 2018, 1:27 PM
koobs requested changes to this revision.Aug 7 2018, 9:44 AM

Except for this probably requiring a PORTREVISION bump since the package contents are changed, it appears fine, assuming *all* the lines being removed are relevant to that GCC_RUNTIME.

Though I can make a few assumptions (guesses), I'm not familiar enough with the port or that ex.script mechanism to know

This revision now requires changes to proceed.Aug 7 2018, 9:44 AM

Except for this probably requiring a PORTREVISION bump since the package contents are changed, it appears fine, assuming *all* the lines being removed are relevant to that GCC_RUNTIME.

Though I can make a few assumptions (guesses), I'm not familiar enough with the port or that ex.script mechanism to know

The ex script was supposed to add two lines in all scripts to set LD_LIBRARY_PATH and since we don't need to set that anymore (hence removed GCC dependency), the whole script is now irrelevant (as @antoine correctly spotted)

farrokhi updated this revision to Diff 46377.Aug 7 2018, 10:10 AM

Bump PORTREVISION

koobs accepted this revision.Aug 7 2018, 10:46 PM
koobs edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 7 2018, 10:46 PM
This revision was automatically updated to reflect the committed changes.