Page MenuHomeFreeBSD
Differential D16604

Rack sends extra FIN
ClosedPublic
Actions

Authored by rrs on Aug 6 2018, 9:31 AM.
Tags
None
Referenced Files
F133570268: D16604.id46332.diff
Sun, Oct 26, 5:45 PM
F133570267: D16604.id.diff
Sun, Oct 26, 5:45 PM
F133570264: D16604.id46409.diff
Sun, Oct 26, 5:45 PM
F133534761: D16604.diff
Sun, Oct 26, 11:51 AM
Unknown Object (File)
Sat, Oct 25, 12:37 PM
Unknown Object (File)
Wed, Oct 22, 11:32 PM
Unknown Object (File)
Thu, Oct 9, 10:54 AM
Unknown Object (File)
Wed, Oct 8, 12:29 AM
View All 72 Files
Subscribers
imp

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rS337455: Fix a small bug in rack where it will
Summary

There is a small bug in rack where when closing a connection it will
send an extra FIN. This is because it checks the wrong variable
and should not allow a goto send unless the FIN has never been sent.
A timer will set the ACK_NOW flag.

Test Plan

Use a the attached packetdrill script to make sure the problem goes away.

D16604.pkt2 KBDownload

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rrs created this revision.Aug 6 2018, 9:31 AM
tuexen accepted this revision.Aug 6 2018, 7:04 PM
tuexen edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 6 2018, 7:04 PM
Closed by commit rS337455: Fix a small bug in rack where it will (authored by rrs). · Explain WhyAug 8 2018, 1:37 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2018, 1:37 PM

Revision Contents
Changeset List

PathSize
head/
sys/
netinet/
tcp_stacks/
11 lines

Diff 46409

View Options

head/sys/netinet/tcp_stacks/rack.c

Loading...