Page MenuHomeFreeBSD

Rack sends extra FIN

Authored by rrs on Aug 6 2018, 9:31 AM.



There is a small bug in rack where when closing a connection it will
send an extra FIN. This is because it checks the wrong variable
and should not allow a goto send unless the FIN has never been sent.
A timer will set the ACK_NOW flag.

Test Plan

Use a the attached packetdrill script to make sure the problem goes away.

Diff Detail

rS FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rrs created this revision.Aug 6 2018, 9:31 AM
tuexen accepted this revision.Aug 6 2018, 7:04 PM
tuexen edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Aug 6 2018, 7:04 PM
This revision was automatically updated to reflect the committed changes.