Make sure the rtld(1) error messages go to stderr, not stdout.
ClosedPublic
Actions

Authored by trasz on Jul 31 2018, 4:38 PM.

Details

Reviewers

Commits

rS337067: Make sure the rtld(1) error messages go to stderr, not stdout.

Summary

Make sure the rtld(1) error messages go to stderr, not stdout.
While fix capitalization of a few nearby strings, add "rtld: " prefix
so it's obvious where the message come from, and return zero
when "-h" is used.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18459
Build 18164: arc lint + arc unit

Event Timeline

trasz created this revision.Jul 31 2018, 4:38 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2018, 4:38 PM

Harbormaster completed remote builds in B18459: Diff 46075.Jul 31 2018, 4:38 PM

trasz edited the summary of this revision. (Show Details)Jul 31 2018, 4:39 PM

trasz added a reviewer: kib.

rtld is an informal name. Officially it is ld-elf.so.1 for native, and ld-elf32.so.1 for compat32.

Add _BASENAME_RTLD and use it in error messages.

Harbormaster completed remote builds in B18465: Diff 46087.Jul 31 2018, 6:46 PM

Ok, how about now? I"m not sure about the _BASENAME, tbh.

kib accepted this revision.Aug 1 2018, 5:26 PM

kib added inline comments.

libexec/rtld-elf/paths.h
50 ↗	(On Diff #46087)	Do these ifdefs around BASENAME and PATH still make sense ? Before your change, it was a mechanism to get '32' defines not overridden. You can change it in the followup commit.