Page MenuHomeFreeBSD

Move etc/shells to lib/libc/gen/shells
ClosedPublic

Authored by brd on Jul 27 2018, 5:38 AM.

Details

Summary

Switch to using CONFS to handle install.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 18367
Build 18083: arc lint + arc unit

Event Timeline

brd created this revision.Jul 27 2018, 5:38 AM
brd updated this revision to Diff 45953.Jul 28 2018, 3:41 PM

After discussion with Will, we decided libc was a better place for shells,
since that is where getusershell(3) comes from.

brd retitled this revision from Move etc/shells to usr.bin/chpass/shells to Move etc/shells to lib/libc/gen/shells.Jul 28 2018, 3:42 PM
will added a comment.Jul 28 2018, 4:31 PM

Summarizing discussion:

  • chpass is the program that implements chsh which modifies /etc/shells, so it makes sense to install with this program.
  • However, one could, strictly speaking, choose not to install chpass on a system, either because it will never update the shells list, or they edit it through other means.
  • Additionally, /etc/shells is read by getusershell(3) in libc, which _is_ required by some programs, in particular su(1). So it could make more sense to install this file with libc instead.
will accepted this revision.Jul 28 2018, 4:36 PM
This revision is now accepted and ready to land.Jul 28 2018, 4:36 PM
This revision was automatically updated to reflect the committed changes.