Page MenuHomeFreeBSD

Be more conservative about setting hw.uart.console
ClosedPublic

Authored by imp on Jul 26 2018, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 11:36 PM
Unknown Object (File)
Jan 5 2024, 1:42 PM
Unknown Object (File)
Dec 20 2023, 2:28 AM
Unknown Object (File)
Nov 22 2023, 3:10 PM
Unknown Object (File)
Nov 11 2023, 9:02 AM
Unknown Object (File)
Nov 9 2023, 2:26 AM
Unknown Object (File)
Nov 3 2023, 12:34 PM
Unknown Object (File)
Oct 10 2023, 8:02 AM
Subscribers
None

Details

Summary

Note when we've found a 8250 PNP node. Only try to set hw.uart.console
if we see one (otherwise ignore serial hints). The 8250 is the only
one known to have I/O ports, so limit the guessing to when we've
positively seen one. And limit this to x86 since that's the only
platform where we have I/O ports. Otherwise, we'd set the serial port
to something crazy for the platform and fall off the cliff early in
boot.

also added matt macy because he's doing the EPOC stuff which will have a x86 use-case.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp added reviewers: andrew, mmacy, markj.
imp edited the summary of this revision. (Show Details)

If someone sets hw.uart.console, assume they know what they are doing
and don't second guess them.

This fixes my boot-time hang on ThunderX. I don't know the code well enough to mark it reviewed, but it seems sane to me.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2018, 7:44 PM
This revision was automatically updated to reflect the committed changes.