devel/libconfig: update to 1.7.2
ClosedPublic
Actions

Authored by fernape on Jul 25 2018, 5:24 PM.

Details

Reviewers

tcberner
tz

Commits

rP476517: devel/libconfig: update to 1.7.2

Summary

Triggered by PR 229961

Change to USE_GH
Bump PORTREVISION of dependant ports.

Maintainer timeout on August 5th.

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
poudriere build for dependant port audio/umurmur in 10.4amd64 OK:
run test in 10.4 amd64 for audio/umurmur

It picks up the correct library:

ldd umurmurd
umurmurd:
               libssl.so.7 => /usr/lib/libssl.so.7 (0x80083f000)
               libcrypto.so.7 => /lib/libcrypto.so.7 (0x800aab000)
               libconfig.so.11 => /usr/local/lib/libconfig.so.11 (0x800ea3000)
               libprotobuf-c.so.1 => /usr/local/lib/libprotobuf-c.so.1 (0x8010af000)
               libc.so.7 => /lib/libc.so.7 (0x8012b9000)

Tested with config files:

/usr/local/etc/umurmur/umurmur.conf
/usr/local/etc/umurmur/umurmur.conf.sample

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Jul 25 2018, 5:24 PM

Herald added a subscriber: mat. · View Herald TranscriptJul 25 2018, 5:24 PM

Harbormaster completed remote builds in B18329: Diff 45835.Jul 25 2018, 5:24 PM

tcberner added inline comments.Aug 2 2018, 4:55 AM

devel/libconfig/Makefile
14 ↗	(On Diff #45835)	^ CONFLICTS looks to be in the wrong spot

fernape added inline comments.Aug 2 2018, 4:20 PM

devel/libconfig/Makefile
14 ↗	(On Diff #45835)	Where exactly? I had a look at databases/qof (mentioned as an example in the documentation) and its CONFLICTS_INSTALL is right below LICENSE (no portlint complaints in that place).

tcberner added inline comments.Aug 2 2018, 6:12 PM

devel/libconfig/Makefile
14 ↗	(On Diff #45835)	portlint is not perfect -- and the documentation not quit clear -- but I would say that between the dependency block and uses is wrong :) I would say it belongs to 15.9 or 15.11, some I would put it between GH_ACCOUNT and INFO. -- but @mat is the best judge on these things.

mat added inline comments.Aug 3 2018, 10:08 AM

devel/libconfig/Makefile
14 ↗	(On Diff #45835)	portlint is not the reference. It is a static lint tool that is almost not always wrong. The reference is https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html and I agree, it's a standard variable, so 15.9.