Page MenuHomeFreeBSD

devel/libconfig: update to 1.7.2

Authored by fernape on Jul 25 2018, 5:24 PM.



Triggered by PR 229961

  • Change to USE_GH
  • Bump PORTREVISION of dependant ports.

Maintainer timeout on August 5th.

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • poudriere build for dependant port audio/umurmur in 10.4amd64 OK:
  • run test in 10.4 amd64 for audio/umurmur

It picks up the correct library:

ldd umurmurd
      => /usr/lib/ (0x80083f000)
      => /lib/ (0x800aab000)
      => /usr/local/lib/ (0x800ea3000)
      => /usr/local/lib/ (0x8010af000)
      => /lib/ (0x8012b9000)

Tested with config files:


Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

14 ↗(On Diff #45835)

^ CONFLICTS looks to be in the wrong spot

14 ↗(On Diff #45835)

Where exactly? I had a look at databases/qof (mentioned as an example in the documentation) and its CONFLICTS_INSTALL is right below LICENSE (no portlint complaints in that place).

14 ↗(On Diff #45835)

portlint is not perfect -- and the documentation not quit clear -- but I would say that between the dependency block and uses is wrong :)

I would say it belongs to 15.9 or 15.11, some I would put it between GH_ACCOUNT and INFO. -- but @mat is the best judge on these things.

14 ↗(On Diff #45835)

portlint is not the reference. It is a static lint tool that is almost not always wrong.

The reference is and I agree, it's a standard variable, so 15.9.

fernape added inline comments.
14 ↗(On Diff #45835)

Thanks for the input :-)

fernape marked an inline comment as done.

Fix PORTREVISION for net-im/tox

This revision is now accepted and ready to land.Aug 4 2018, 10:10 AM
This revision was automatically updated to reflect the committed changes.