The ICMP echo is too small
ClosedPublic
Actions

Authored by rrs on Jul 18 2018, 10:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 28, 9:34 PM

	Unknown Object (File)
	Sun, Dec 14, 2:08 AM

	Unknown Object (File)
	Sun, Dec 14, 12:04 AM

	Unknown Object (File)
	Fri, Dec 12, 12:26 AM

	Unknown Object (File)
	Dec 1 2025, 9:44 PM

	Unknown Object (File)
	Nov 21 2025, 2:59 AM

	Unknown Object (File)
	Nov 21 2025, 2:59 AM

	Unknown Object (File)
	Nov 21 2025, 2:56 AM

View All 90 Files

Subscribers

imp

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rS336465: Bump the ICMP echo limits to match the RFC

Summary

The amount we echo (8 bytes) is from the 1980's and the router requirements document
requires it to be much higher

Test Plan

Grow it and make sure we reflect larger packets back

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rrs created this revision.Jul 18 2018, 10:46 PM

Add a fullstop at the end of the comment.

This revision is now accepted and ready to land.Jul 18 2018, 10:48 PM

Closed by commit rS336465: Bump the ICMP echo limits to match the RFC (authored by rrs). · Explain WhyJul 18 2018, 10:50 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJul 18 2018, 10:50 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

netinet/

ip_icmp.c

4 lines

tcp_stacks/

rack.c

2 lines

Diff 45502

View Options

head/sys/netinet/ip_icmp.c