Page MenuHomeFreeBSD

Add myself (0mp) as a ports committer, add my key, update news and adapt some tools to my username.
ClosedPublic

Authored by 0mp on Jul 17 2018, 12:07 AM.

Details

Summary

Apart from the files I am supposed to update with my information I also edited two scripts, which didn't work due to the leading 0 in my username. Those scripts are share/pgpkeys/checkkey.sh and share/pgpkeys/addkey.sh.

I guess I should update those scripts in a separate commit, right?

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

0mp created this revision.Jul 17 2018, 12:07 AM
mat added a comment.Jul 17 2018, 6:38 AM

Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

mat added subscribers: wblock, des.

Also, adding @des for addkey.sh and @wblock for checkkey.sh.

0mp updated this revision to Diff 45439.Jul 18 2018, 1:35 AM

Thanks, @mat! I was always curious why Phabricator does not add any context to my diffs.

Here's a diff generated with svn diff -x -U9999. I'll try to get familiar with the arcanist soon.

mat accepted this revision.Jul 18 2018, 7:06 AM

This looks ok to me, you can commit the changes, but for the scripts, I would still like feedback from their authors.

This revision is now accepted and ready to land.Jul 18 2018, 7:06 AM
This revision was automatically updated to reflect the committed changes.