Reorder PGA_REFERENCED and pmap_ts_referenced()
ClosedPublic
Actions

Authored by alc on Jul 15 2018, 5:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 30, 10:23 PM

	Unknown Object (File)
	Tue, Sep 30, 6:22 AM

	Unknown Object (File)
	Tue, Sep 30, 1:17 AM

	Unknown Object (File)
	Sun, Sep 28, 6:41 PM

	Unknown Object (File)
	Sun, Sep 28, 3:52 PM

	Unknown Object (File)
	Sun, Sep 28, 12:07 PM

	Unknown Object (File)
	Jul 7 2025, 5:55 AM

	Unknown Object (File)
	Jul 3 2025, 8:45 AM

View All 80 Files

Subscribers

imp

Details

Reviewers

kib
markj

Commits

rS336314: Test PGA_REFERENCED after calling pmap_ts_referenced(), rather than before,

Summary

As discussed in one of the pmap patches, the PGA_REFERENCED test should really come after the pmap_ts_referenced() call.

vm_swapout.c already happens to perform the checks in this order.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc created this revision.Jul 15 2018, 5:01 PM

markj accepted this revision.Jul 15 2018, 5:05 PM

markj added inline comments.

vm/vm_pageout.c
1497 ↗	(On Diff #45318)	Style: unneeded braces.

This revision is now accepted and ready to land.Jul 15 2018, 5:05 PM

Style fix.

This revision now requires review to proceed.Jul 15 2018, 5:21 PM

kib accepted this revision.Jul 15 2018, 5:27 PM

This revision is now accepted and ready to land.Jul 15 2018, 5:27 PM

Closed by commit rS336314: Test PGA_REFERENCED after calling pmap_ts_referenced(), rather than before, (authored by alc). · Explain WhyJul 15 2018, 7:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJul 15 2018, 7:25 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_pageout.c

57 lines

Diff 45323

View Options

Reorder PGA_REFERENCED and pmap_ts_referenced()ClosedPublicActions