Page MenuHomeFreeBSD
Differential D16277

Reorder PGA_REFERENCED and pmap_ts_referenced()
ClosedPublic
Actions

Authored by alc on Jul 15 2018, 5:01 PM.
Tags
None
Referenced Files
F161598834: D16277.diff
Sun, Jul 5, 5:48 AM
Unknown Object (File)
Fri, Jul 3, 12:58 AM
Unknown Object (File)
Thu, Jul 2, 5:09 PM
Unknown Object (File)
May 9 2026, 10:27 PM
Unknown Object (File)
May 9 2026, 10:19 PM
Unknown Object (File)
May 1 2026, 9:30 AM
Unknown Object (File)
May 1 2026, 9:21 AM
Unknown Object (File)
Apr 29 2026, 6:32 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rS336314: Test PGA_REFERENCED after calling pmap_ts_referenced(), rather than before,
Summary

As discussed in one of the pmap patches, the PGA_REFERENCED test should really come after the pmap_ts_referenced() call.

vm_swapout.c already happens to perform the checks in this order.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alc created this revision.Jul 15 2018, 5:01 PM
markj accepted this revision.Jul 15 2018, 5:05 PM
markj added inline comments.
vm/vm_pageout.c
1497 ↗(On Diff #45318)

Style: unneeded braces.

This revision is now accepted and ready to land.Jul 15 2018, 5:05 PM
alc updated this revision to Diff 45321.Jul 15 2018, 5:21 PM

Style fix.

This revision now requires review to proceed.Jul 15 2018, 5:21 PM
kib accepted this revision.Jul 15 2018, 5:27 PM
This revision is now accepted and ready to land.Jul 15 2018, 5:27 PM
Closed by commit rS336314: Test PGA_REFERENCED after calling pmap_ts_referenced(), rather than before, (authored by alc). · Explain WhyJul 15 2018, 7:25 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 15 2018, 7:25 PM

Revision Contents
Changeset List

PathSize
head/
sys/
vm/
57 lines

Diff 45323

View Options

head/sys/vm/vm_pageout.c

Loading...