Sprinkle bits around to make ports build on tier2/gcc targets

[linimon]

Summary

Most of the ports were missing compiler:* USES flags. A few were
simply missing USE_CSTD=gnu99, as evidenced in the error messages.

Some are just plain broken (math/superlu_mt is a runaway on powerpc64), so mark
as such.

Test Plan

Only test built on powerpc64.

[jbeich]

multimedia/libvpx/Makefile

70 ↗

(On Diff #44881)

Why do you need this in addition to USES=compiler:c++11-lib? See rP472311.

[jhibbits]

multimedia/libvpx/Makefile

70 ↗

(On Diff #44881)

I don't. This was leftovers. I thought I had cleaned up everything during my tree diff move, but apparently some things slipped through. Sorry about that.

[jhibbits]

Revert a no-longer-necessary diff against libvpx. There may be more, as I did
the work on one tree and submitted the diff from another tree.

[jbeich]

games/apricots/Makefile

25

CXXFLAGS.clang is only supported by default in base system. Try adding the following:

USES=	compiler

CXXFLAGS+=	${CXXFLAGS_${CHOSEN_COMPILER_TYPE}}

Ditto in other ports. Also, keep separator consistent with CXXFLAGS_powerpc64 support in Mk/bsd.port.mk: replace CXXFLAGS.clang (dot) with CXXFLAGS_clang (underscore).

[linimon]

deskutils/zim/Makefile

22

These two changes seem unneccessary.

graphics/gnash/Makefile

29

I will sort these before my testing.

math/superlu_mt/Makefile

23

I have already committed this, as it needed no testing.

[linimon]

graphics/osg/Makefile

7

Why the change here?

textproc/tinyxml2/Makefile

7

Also seems unneeded?

[linimon]

For this run I will also try to add the following conditional to mail/exim/Makefile:

.if ${CHOSEN_COMPILER_TYPE} == gcc
EXIM_WARN_FLAGS?= -Wno-logical-op-parentheses -Wno-macro-redefined -Wno-parentheses -Wno-dangling-else
.endif

[jhibbits]

Thanks for the review, guys. It's quite obvious now that my patch is more WIP than complete and ready, but I think the bulk is still good.

deskutils/zim/Makefile

22

Yup, I think I had added a compiler: directive in there, then just removed the directive instead of reverting the whole file.

graphics/osg/Makefile

7

Because this can already build on tier2 archs, so it needs to be rebuilt.

textproc/tinyxml2/Makefile

7

Same as above, this is needed to force-rebuild the port.

[linimon]

Overcome by subsequent events.

[linimon]

Overcome by subsequent events.