ig(4): add support for Apollo Lake I2C controllers
ClosedPublic
Actions

Authored by gonzo on Jul 4 2018, 3:08 AM.

Details

Reviewers

avg

Commits

rS339029: MFC r336050-r336051, r336142, r336326, r337719
rS336050: ig4(4): add support for Apollo Lake I2C controllers

Summary

Add PCI ids for I2C controllers on Apollo Lake platform

Also refactor probe function a bit.

Test Plan

Driver recognizes controllers on Atom E3930 board and scans
shows devices attached at the same addresses as on Linux.
I don't have drivers for those devices (camera sonsors) and
can't verify actual tranfer functionality.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo created this revision.Jul 4 2018, 3:08 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 4 2018, 3:08 AM

Harbormaster completed remote builds in B17830: Diff 44840.Jul 4 2018, 3:08 AM

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

avg accepted this revision.Jul 4 2018, 10:58 AM

This revision is now accepted and ready to land.Jul 4 2018, 10:58 AM

Closed by commit rS336050: ig4(4): add support for Apollo Lake I2C controllers (authored by gonzo). · Explain WhyJul 6 2018, 9:22 PM

This revision was automatically updated to reflect the committed changes.

In D16120#341805, @avg wrote:

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

Thanks for approval. I'll look into adding MODULE_PNP_INFO as the next refactoring iteration.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ichiic/

ig4_pci.c

110 lines

ig4_var.h

2 lines

Diff 44975

View Options

head/sys/dev/ichiic/ig4_pci.c