Page MenuHomeFreeBSD

ig(4): add support for Apollo Lake I2C controllers
ClosedPublic

Authored by gonzo on Jul 4 2018, 3:08 AM.

Details

Summary

Add PCI ids for I2C controllers on Apollo Lake platform

Also refactor probe function a bit.

Test Plan

Driver recognizes controllers on Atom E3930 board and scans
shows devices attached at the same addresses as on Linux.
I don't have drivers for those devices (camera sonsors) and
can't verify actual tranfer functionality.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gonzo created this revision.Jul 4 2018, 3:08 AM
avg added a comment.Jul 4 2018, 10:58 AM

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

avg accepted this revision.Jul 4 2018, 10:58 AM
This revision is now accepted and ready to land.Jul 4 2018, 10:58 AM
This revision was automatically updated to reflect the committed changes.
gonzo added a comment.Jul 6 2018, 9:23 PM
In D16120#341805, @avg wrote:

LGTM, thanks!
Maybe also add MODULE_PNP_INFO now that the IDs are in a table?

Thanks for approval. I'll look into adding MODULE_PNP_INFO as the next refactoring iteration.