Page MenuHomeFreeBSD
Differential D16117

muge(4): add DTB blob as one more possible source of MAC address
ClosedPublic
Actions

Authored by gonzo on Jul 3 2018, 8:27 PM.
Tags
None
Referenced Files
F137935340: D16117.id44832.diff
Thu, Nov 27, 10:33 AM
Unknown Object (File)
Tue, Nov 25, 3:57 PM
Unknown Object (File)
Thu, Nov 20, 9:08 PM
Unknown Object (File)
Thu, Nov 20, 9:08 PM
Unknown Object (File)
Thu, Nov 20, 9:05 PM
Unknown Object (File)
Thu, Nov 20, 9:05 PM
Unknown Object (File)
Thu, Nov 20, 9:04 PM
Unknown Object (File)
Thu, Nov 20, 8:56 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
arshankhanifar_gmail.com
Commits
rS335925: muge(4): add DTB blob as one more possible source of MAC address
Summary

Overall procedure is to find DTB node with comaptible string "usbVID,PID"
and try to obtain MAC address from mac-address and local-mac-address fields

Test Plan

Tested in RPi3B+, FreeBSD uses MAC address matching the one provided by the firmware

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gonzo created this revision.Jul 3 2018, 8:27 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2018, 8:27 PM
Harbormaster completed remote builds in B17824: Diff 44827.Jul 3 2018, 8:27 PM
gonzo added a reviewer: arshankhanifar_gmail.com.Jul 3 2018, 8:28 PM
emaste added inline comments.Jul 3 2018, 8:39 PM
sys/dev/usb/net/if_muge.c
1438 ↗(On Diff #44827)

Why FreeBSD-specific?

1543 ↗(On Diff #44827)

Perhaps we should refactor this into a muge_set_mac_addr or such first? Or I'm happy to do it afterwards.

gonzo added inline comments.Jul 3 2018, 8:42 PM
sys/dev/usb/net/if_muge.c
1438 ↗(On Diff #44827)

Copypaste mistake

1543 ↗(On Diff #44827)

Will do

gonzo updated this revision to Diff 44828.Jul 3 2018, 9:38 PM
  • Added documentation
  • Removed some stale comments
  • Refactored MAC-stting part into muge_set_mac_addr function
Harbormaster completed remote builds in B17825: Diff 44828.Jul 3 2018, 9:38 PM
emaste accepted this revision.Jul 3 2018, 9:43 PM

Some suggestions but overall I think this is fine. I can futz with it after commit otherwise.

sys/dev/usb/net/if_muge.c
1468 ↗(On Diff #44828)

extra 'r' in store

1509 ↗(On Diff #44828)

matching

1547–1551 ↗(On Diff #44828)

This comment is probably not correct (at least, not correct at this location) now.

1569–1570 ↗(On Diff #44828)

Given this is moved out into a function we could use early-return instead

This revision is now accepted and ready to land.Jul 3 2018, 9:43 PM
gonzo updated this revision to Diff 44832.Jul 3 2018, 10:30 PM
  • Spelling fixes
  • A bit more refactoring
This revision now requires review to proceed.Jul 3 2018, 10:30 PM
Harbormaster completed remote builds in B17826: Diff 44832.Jul 3 2018, 10:30 PM
emaste accepted this revision.Jul 4 2018, 12:03 AM
This revision is now accepted and ready to land.Jul 4 2018, 12:03 AM
Closed by commit rS335925: muge(4): add DTB blob as one more possible source of MAC address (authored by gonzo). · Explain WhyJul 4 2018, 3:03 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
usb/
net/
193 lines

Diff 44839

View Options

head/sys/dev/usb/net/if_muge.c

Loading...