sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMA
ClosedPublic
Actions

Authored by sbruno on Jul 3 2018, 4:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 7, 4:48 PM

	Unknown Object (File)
	Sun, Nov 2, 2:56 AM

	Unknown Object (File)
	Wed, Oct 29, 4:18 AM

	Unknown Object (File)
	Wed, Oct 29, 4:18 AM

	Unknown Object (File)
	Wed, Oct 29, 4:18 AM

	Unknown Object (File)
	Tue, Oct 28, 10:12 PM

	Unknown Object (File)
	Oct 10 2025, 2:04 AM

	Unknown Object (File)
	Oct 9 2025, 11:56 PM

View All 64 Files

Subscribers

imp

Details

Reviewers

jeff
kib
mjg

Commits

rS336063: Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations

Summary

stripe seems to be unused on targets that don't support NUMA.
Wrap this variable completely inside of #ifdef NUMA. Found with gcc.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sbruno created this revision.Jul 3 2018, 4:12 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2018, 4:12 PM

Harbormaster completed remote builds in B17816: Diff 44809.Jul 3 2018, 4:12 PM

/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c: In function 'zone_import':
/home/sbruno/bsd/fbsd_head/sys/vm/uma_core.c:2774:6: warning: variable 'stripe' set but not used [-Wunused-but-set-variable]
  int stripe;

This revision was not accepted when it landed; it landed in state Needs Review.Jul 7 2018, 1:38 PM

Closed by commit rS336063: Wrap the declaration and assignment of "stripe" with #ifdef NUMA declarations (authored by sbruno). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

uma_core.c

4 lines

Diff 44993

View Options

sys/vm/uma_core.c:zone_import() Wrap stripe variable in #ifdef NUMAClosedPublicActions