Xen blkfront: Fixed wrong error code return in xbd_dump()

[pratyush]

Summary

rc is initialized to 0. Returning 0 here would indicate success.

Return EINVAL instead to indicate the error.

[pratyush]

Any comments?

[royger]

sys/dev/xen/blkfront/blkfront.c

605

length is of type size_t, which is an unsigned type, so checking it against < 0 is useless. Also if length == 0 you should just return 0.

C
if ( length == 0)
    return 0;

Is IMO the correct fix. Although the code is already functionally correct because it returns 0 when length == 0, which is fine.

[pratyush]

I updated the diff. Your call if you want to commit the change or leave it as it is.

[pratyush]

Committed by Roger as rS336895