Allow the linuxulator to use a common cpu_set_syscall_retval
ClosedPublic
Actions

Authored by andrew on Jun 25 2018, 2:48 PM.

Details

Reviewers

emaste
manu

Commits

rS335649: Make cpu_set_syscall_retval common between the existing FreeBSD ABI and

Summary

Use SV_ABI_ERRNO to get the correct errno, allowing us to reuse
cpu_set_syscall_retval.

While here preserve x1 as is done on Linux.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 25 2018, 2:48 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 25 2018, 2:48 PM

Harbormaster completed remote builds in B17609: Diff 44424.Jun 25 2018, 2:48 PM

Use the correct variable in the Linuxulator code

Harbormaster completed remote builds in B17610: Diff 44425.Jun 25 2018, 3:33 PM

emaste added inline comments.Jun 25 2018, 3:40 PM

sys/arm64/linux/linux_sysvec.c
147 ↗	(On Diff #44424)	`td->td_frame->tf_x[1]`

Use td->td_frame

Harbormaster completed remote builds in B17611: Diff 44429.Jun 25 2018, 4:54 PM

emaste accepted this revision.Jun 25 2018, 5:44 PM

This revision is now accepted and ready to land.Jun 25 2018, 5:44 PM

Closed by commit rS335649: Make cpu_set_syscall_retval common between the existing FreeBSD ABI and (authored by andrew). · Explain WhyJun 25 2018, 10:36 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJun 25 2018, 10:36 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

arm64/

vm_machdep.c

3 lines

linux/

linux_sysvec.c

20 lines

Diff 44445

View Options

head/sys/arm64/arm64/vm_machdep.c