vm: stop passing M_ZERO when allocating radix nodes
ClosedPublic
Actions

Authored by mjg on Jun 24 2018, 7:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 7:28 PM

	Unknown Object (File)
	Thu, Nov 28, 5:28 AM

	Unknown Object (File)
	Sep 17 2024, 9:26 AM

	Unknown Object (File)
	Sep 8 2024, 8:32 PM

	Unknown Object (File)
	Sep 8 2024, 2:57 AM

	Unknown Object (File)
	Sep 7 2024, 5:12 AM

	Unknown Object (File)
	Sep 4 2024, 12:22 PM

	Unknown Object (File)
	Aug 30 2024, 6:09 AM

View All 42 Files

Subscribers

imp

Details

Reviewers

alc
markj
jeff

Commits

rS335600: vm: stop passing M_ZERO when allocating radix nodes

Summary

The three leading fields are explicitely initialized and the rest is supposed to be already zeroed.

This removes one of the most common calls to memset.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Jun 24 2018, 7:16 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 24 2018, 7:16 AM

Harbormaster completed remote builds in B17582: Diff 44375.Jun 24 2018, 7:16 AM

I would add a debug-only dtor which verifies that the child pointers are zeroed.

This revision is now accepted and ready to land.Jun 24 2018, 12:37 PM

There is one already and it can be seen in the diff: vm_radix_node_zone_dtor

Closed by commit rS335600: vm: stop passing M_ZERO when allocating radix nodes (authored by mjg). · Explain WhyJun 24 2018, 1:08 PM

This revision was automatically updated to reflect the committed changes.

Nice change.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_radix.c

14 lines

Diff 44389

View Options

vm: stop passing M_ZERO when allocating radix nodesClosedPublicActions