Page MenuHomeFreeBSD

biology/phyml: update to v3.3.20180621
ClosedPublic

Authored by fernape on Jun 22 2018, 4:23 PM.

Details

Summary

Reported by portscout.

  • Reorder USES and USE_*
Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 10.4 amd64 OK
  • Build test with MPICH2 and OPENMPI in 11.1 amd64 OK

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fernape created this revision.Jun 22 2018, 4:23 PM
tcberner added inline comments.Jun 22 2018, 4:44 PM
biology/phyml/Makefile
7 ↗(On Diff #44310)

^why?

fernape added inline comments.Jun 22 2018, 5:07 PM
biology/phyml/Makefile
7 ↗(On Diff #44310)

Your question indicates that I misunderstood the Handbook :-)

I understand that in situations in which the new version is not numerically bigger than the old one (as in this case), PORTEPOCH much be increased. I searched the ports tree and found several ports with PORTEPOCHs greater than 1 (archivers/rar, astro/google-earth...) so I bumped it from 1 to 2.

tcberner added inline comments.Jun 22 2018, 6:55 PM
biology/phyml/Makefile
7 ↗(On Diff #44310)

You need to bump PORTEPOCH whenever the version would decrease otherwise -- here, the version increases, so no need to bump epoch.

fernape updated this revision to Diff 44347.Jun 23 2018, 3:22 PM

No need to bump PORTEPOCH

tcberner accepted this revision.Jun 23 2018, 3:45 PM
This revision is now accepted and ready to land.Jun 23 2018, 3:45 PM
This revision was automatically updated to reflect the committed changes.