Details
Details
- Reviewers
tcberner - Group Reviewers
kde portmgr O5: Ports Framework (Owns No Changed Paths) - Commits
- rP474468: Add x11-toolkits/py-qt5-quickwidgets, Python bindings for QtQuickWidgets module
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 17762 Build 17551: arc lint + arc unit
Event Timeline
Comment Actions
The Makefile has badly ordered bits. Could you please read Chapter 15. Order of Variables in Port Makefiles and make the appropriates changes.
Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
Comment Actions
Sorry, I based that on one of the existing py-qt5-* ports and forgot to run portlint on that. Should be fine now except the LICENSE bit which is defined in Uses/pyqt.mk.
py-qt5/Makefile | ||
---|---|---|
5 ↗ | (On Diff #44150) | ^ please bump the PORTREVISON too |
Comment Actions
Sorry, I was busy :)
x11-toolkits/py-qt5-quickwidgets/Makefile | ||
---|---|---|
15 | ^ this needs to be converted to |