Page MenuHomeFreeBSD

pyqt: add quickwidgets port
ClosedPublic

Authored by novel on Jun 19 2018, 2:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 9:39 PM
Unknown Object (File)
Feb 9 2024, 8:46 PM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Unknown Object (File)
Jan 27 2024, 11:11 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The Makefile has badly ordered bits. Could you please read Chapter 15. Order of Variables in Port Makefiles and make the appropriates changes.

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

tcberner added inline comments.
x11-toolkits/py-qt5-quickwidgets/Makefile
16 ↗(On Diff #44074)

^ please alphabetize these, and move qmake_build to the end:

USE_QT5=  core gui network qml quick widgets \
          qmake_build
19 ↗(On Diff #44074)

^missing space after =

x11-toolkits/py-qt5-quickwidgets/pkg-plist
5 ↗(On Diff #44074)

^%%API%%

novel marked 3 inline comments as done.
In D15903#336408, @mat wrote:

The Makefile has badly ordered bits. Could you please read Chapter 15. Order of Variables in Port Makefiles and make the appropriates changes.

Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.

Sorry, I based that on one of the existing py-qt5-* ports and forgot to run portlint on that. Should be fine now except the LICENSE bit which is defined in Uses/pyqt.mk.

py-qt5/Makefile
5 ↗(On Diff #44150)

^ please bump the PORTREVISON too

Could you update the diff using arc-diff?

Could you update the diff using arc-diff?

Done.

Sorry, I was busy :)

x11-toolkits/py-qt5-quickwidgets/Makefile
14 ↗(On Diff #44376)

^ this needs to be converted to
USES=qt:5 and USE_QT=

This revision now requires changes to proceed.Jun 30 2018, 7:21 AM

Switch to USES=qt:5 and USE_QT.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.