Page MenuHomeFreeBSD

audio/musicpc: update to 0.30
ClosedPublic

Authored by fernape on Jun 16 2018, 4:35 PM.

Details

Summary

Sent by maintainer in PR 229034

Test Plan
  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
  • run test in 10.4 amd64

Note that I don't have a MPD to test against. I just checked that the program fires up

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fernape created this revision.Jun 16 2018, 4:35 PM
tcberner requested changes to this revision.Jun 16 2018, 9:03 PM

This fails to patch for me on current -- interstingly it works on 10.4...

This revision now requires changes to proceed.Jun 16 2018, 9:03 PM
fernape updated this revision to Diff 43948.Jun 17 2018, 4:27 PM

Fix patching on -CURRENT.

I think my test on 12 passed because I wrongly copied the whole directory (with sources patched)
from my host to the virtual machine running 12.

If we look at the modifications of the patches, it seems to me that patching in 12 is a bit more
peeky than it is in 11.x or 10.x. Were there any changes in the way we do patching?

For this new version:

  • portlint -AC OK
  • poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK

Hi Tobias,

I think I was tricked by the same problem twice today: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228788.

Shouldn't we expect more breaks when 11.2 is released?

tcberner accepted this revision.Jun 17 2018, 7:49 PM

Let's hope not too many :)

This revision is now accepted and ready to land.Jun 17 2018, 7:49 PM
This revision was automatically updated to reflect the committed changes.