Page MenuHomeFreeBSD

lang/phantomjs: Allow building on armv6 and armv7 platforms
ClosedPublic

Authored by loader on Jun 16 2018, 2:26 PM.

Details

Summary

Proposed commit log message:

lang/phantomjs: Allow building on armv6 and armv7 platforms

- Patches for armv6 and armv7 are obtained from www/webkit-gtk3
- Allow building with non-default LOCALBASE
- Fix build with Clang 6.0.0 [0]

PR: 225482 [0]
Reviewed_by: koobs, feld
Approved by: koobs (mentor), feld (maintainner)
Differential_Revision: D15850
Test Plan
  • portlint: OK (

WARN: Makefile: [55]: is _PHANTOMJS_USE_QT_SYSTEM a user-settable option? Consider using WITH_QT_SYSTEM instead.
0 fatal errors and 1 warning found.
)

  • testport: OK (poudriere: 1200065, [armv6, armv7, aarch64, amd64], '', tested)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

loader created this revision.Jun 16 2018, 2:26 PM
loader edited the summary of this revision. (Show Details)Jun 16 2018, 2:29 PM
feld added a comment.Jun 16 2018, 8:14 PM

Let me fire off a build against CURRENT as a sanity check (this might also fix the breakage there)

Are you interested in becoming MAINTAINER as well?

feld accepted this revision.Jun 16 2018, 11:52 PM

LGTM

This revision is now accepted and ready to land.Jun 16 2018, 11:52 PM
In D15850#335277, @feld wrote:

Let me fire off a build against CURRENT as a sanity check (this might also fix the breakage there)
Are you interested in becoming MAINTAINER as well?

Thank you for the offer. I'm new to this and not capable of maintaining this port. Thanks for approving the review. :)

koobs accepted this revision.Jun 18 2018, 11:34 AM
This revision was automatically updated to reflect the committed changes.