Page MenuHomeFreeBSD
Differential D1585

Fix various bugs in Haswell counter definitions
ClosedPublic
Actions

Authored by rstone on Jan 22 2015, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 4:23 AM
Unknown Object (File)
Oct 26 2024, 7:51 PM
Unknown Object (File)
Sep 19 2024, 12:43 PM
Unknown Object (File)
Sep 19 2024, 7:30 AM
Unknown Object (File)
Sep 19 2024, 4:35 AM
Unknown Object (File)
Sep 17 2024, 7:15 PM
Unknown Object (File)
Sep 17 2024, 11:07 AM
Unknown Object (File)
Sep 16 2024, 3:37 PM
View All 77 Files
Subscribers
joe-thestackframe.org

Details

Reviewers
joe-thestackframe.org
Group Reviewers
pmc
Summary
  1. The "WALK_COMPLETED_2M_4M" event incorrectly referenced 4K pages.
  2. The umask for RING0 and RING123 events was reversed.
Test Plan

5294a3d11d8e2a6d2e04cd07c5fd14c3ece01bc0
a3d81af282464e4df2444a34debc7fe917f1949a
86620a986f41a6e21143fb9ecfa1cc9aac15d976
1896f230aa15d344f4200808ba692a5ca74e009a
25e9462aaf10ade1fd8b2e20c2f4757c74049a6b
b2d7de40e14b960a7ef63582c9a9cb4e0a291cf5
95f2070fe01fe14638be7aa0dd0c00633d862594

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rstone updated this revision to Diff 3307.Jan 22 2015, 4:01 AM
rstone retitled this revision from to Fix various bugs in Haswell counter definitions.
rstone edited the test plan for this revision. (Show Details)
rstone updated this object.
rstone added a reviewer: pmc.Jan 22 2015, 4:09 AM
joe-thestackframe.org accepted this revision.Mar 5 2015, 11:56 PM
joe-thestackframe.org added a reviewer: joe-thestackframe.org.
joe-thestackframe.org added a subscriber: joe-thestackframe.org.

Verified changes with Intel documentation. Looks good.

This revision is now accepted and ready to land.Mar 5 2015, 11:56 PM
rstone closed this revision.Mar 10 2015, 11:18 PM

committed as r279830

Revision Contents
Changeset List

PathSize
sys/
dev/
hwpmc/
12 lines

Diff 3307

View Options

sys/dev/hwpmc/pmc_events.h

Loading...