Page MenuHomeFreeBSD
Differential D15763

powerpc64: Avoid type promotion
ClosedPublic
Actions

Authored by breno.leitao_gmail.com on Jun 11 2018, 7:27 PM.

Details

Reviewers
wma
jhibbits
Commits
rS335013: powerpc64/powernv: Avoid type promotion
Summary

There is a type promotion that transform count = -1 into a unsigned int causing
the default TCE SEG SIZE not being returned on a Boston POWER9 machine.
This machine does not have the 'ibm,supported-tce-sizes' entries, thus, count
is set to -1, and the function continue to execute instead of returning.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

breno.leitao_gmail.com updated this revision to Diff 43616.Jun 11 2018, 7:53 PM

Better approach forcing promotion.

jhibbits added a comment.Jun 11 2018, 9:10 PM

This can be simplified to just "if (count < (int)sizeof(cell_t))"

breno.leitao_gmail.com updated this revision to Diff 43623.Jun 11 2018, 9:41 PM

Adjusting to follow jhibbits' suggestion.

wma added inline comments.Jun 12 2018, 4:34 AM
sys/powerpc/powernv/opal_pci.c
224 ↗(On Diff #43623)

Looks good, except the semicolon at the end ;)

breno.leitao_gmail.com updated this revision to Diff 43652.Jun 12 2018, 1:00 PM

Fixing silly error.

jhibbits accepted this revision.Jun 12 2018, 6:45 PM
This revision is now accepted and ready to land.Jun 12 2018, 6:45 PM
Closed by commit rS335013: powerpc64/powernv: Avoid type promotion (authored by leitao). · Explain WhyJun 12 2018, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43668

View Options

head/sys/powerpc/powernv/opal_pci.c

Loading...