Page MenuHomeFreeBSD

powerpc64: Avoid type promotion
ClosedPublic

Authored by breno.leitao_gmail.com on Jun 11 2018, 7:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 16, 11:26 PM
Unknown Object (File)
Sun, Jun 15, 7:23 PM
Unknown Object (File)
Sun, Jun 15, 10:50 AM
Unknown Object (File)
Sat, Jun 14, 7:48 PM
Unknown Object (File)
Sat, Jun 14, 7:06 AM
Unknown Object (File)
Fri, Jun 13, 3:13 PM
Unknown Object (File)
Fri, Jun 13, 11:30 AM
Unknown Object (File)
Thu, Jun 12, 11:29 AM
Subscribers

Details

Summary

There is a type promotion that transform count = -1 into a unsigned int causing
the default TCE SEG SIZE not being returned on a Boston POWER9 machine.
This machine does not have the 'ibm,supported-tce-sizes' entries, thus, count
is set to -1, and the function continue to execute instead of returning.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This can be simplified to just "if (count < (int)sizeof(cell_t))"

Adjusting to follow jhibbits' suggestion.

sys/powerpc/powernv/opal_pci.c
224 ↗(On Diff #43623)

Looks good, except the semicolon at the end ;)

This revision is now accepted and ready to land.Jun 12 2018, 6:45 PM
This revision was automatically updated to reflect the committed changes.