Page MenuHomeFreeBSD

math/cryptominisat and math/py-cryptominisat: Update to 5.6.1.
ClosedPublic

Authored by arrowd on Jun 10 2018, 12:09 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tcberner added inline comments.
math/cryptominisat/Makefile
4 ↗(On Diff #43541)

^ you could switch this to DISTVERSION

23 ↗(On Diff #43541)

^ think about switching to cmake:outsource while you're here

26 ↗(On Diff #43541)
CMAKE_ON= NOM4RI
CMAKE_OFF= ENABLE_PYTHON_INTERFACE

is maybe a bit more readable.

math/py-cryptominisat/Makefile
4 ↗(On Diff #43541)

^ same here

math/py-cryptominisat/files/patch-setup.py.in
9 ↗(On Diff #43541)

Why is this change needed, ... ah, because you're not using cmake anymore here.

You should probably reinplace ${CC} instead of using 'cc' directly in the patch.

This revision now requires changes to proceed.Jun 10 2018, 2:58 PM

You could also think about making the python one a slave of the other while you're here.

mat added inline comments.
math/cryptominisat/Makefile
15 ↗(On Diff #43541)

This is not needed.

18 ↗(On Diff #43541)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

20–21 ↗(On Diff #43541)

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

math/py-cryptominisat/Makefile
18 ↗(On Diff #43541)

Python 2.6 was removed 4 and a half years ago, you could s/-2.7/2.7/.

arrowd marked 9 inline comments as done.
  • Address comments.
  • Relax required python version. It seems to work with 3.6 too.
math/py-cryptominisat/Makefile
29–34 ↗(On Diff #43593)

Is there a reason to run sed 6 times instead of just once?

arrowd marked an inline comment as done.
  • Simplify REINPLACE_CMD calls.
  • Use my @FreeBSD.org email.
This revision is now accepted and ready to land.Jun 17 2018, 7:48 PM
This revision was automatically updated to reflect the committed changes.