Page MenuHomeFreeBSD

Update devel/kdevelop, devel/kdev-python and devel/kdev-php to 5.2.3.
ClosedPublic

Authored by arrowd on May 28 2018, 6:02 PM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arrowd created this revision.May 28 2018, 6:02 PM

You should add kde as a group reviewer too :)

tcberner added inline comments.May 28 2018, 8:40 PM
devel/kdevelop/Makefile
21 ↗(On Diff #43082)

^ I think you need to add some cmake flag/patch so that i only picks up llvm60, as it checks against multiple versions, it could be, possibly, that it would use llvm50 if that is also installed.

devel/kdevelop/pkg-plist
373 ↗(On Diff #43082)

^ this is probably an existing error in the plist -- and os supposed to be
lib/cmake/KDevPlatform/KDevPlatformTargets-release.cmake

unless it is indeed
lib/cmake/KDevPlatform/KDevPlatformTargets-debug.cmake when having WITH_DEBUG set.

arrowd added inline comments.May 29 2018, 8:30 AM
devel/kdevelop/Makefile
21 ↗(On Diff #43082)

Judging from FindLLVM.cmake/FindClang.cmake, it starts searching from a newest version. And since llvm60 is now guaranteed to be pulled in as dependency, I think there is no need in explicit setting of LLVM version in Makefile.

devel/kdevelop/pkg-plist
373 ↗(On Diff #43082)

Yep, it is debug when building WITH_DEBUG=1.

tcberner accepted this revision.May 29 2018, 5:06 PM

Great, in that case, go ahead :)

This revision is now accepted and ready to land.May 29 2018, 5:06 PM
This revision was automatically updated to reflect the committed changes.