Unlike 'NONE' this should have *all* permissions. It mostly
exists to shut up the developer warning that asks you to add a license
Details
Details
- Reviewers
0mp - Group Reviewers
O5: Ports Framework portmgr - Commits
- rP470963: Metaports do not have any files, they do not need a license.
I tried adding LICENSE=METAPORT to the metaport USES but it gets
included to late and doesn't help.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| Mk/bsd.licenses.db.mk | ||
|---|---|---|
| 404 ↗ | (On Diff #43044) | I am not sure if it should be included in those groups. This license is not approved by those organizations/standards, right? |
| Mk/bsd.licenses.db.mk | ||
|---|---|---|
| 404 ↗ | (On Diff #43044) | Correct, but anyone who wants to limit to those groups should not be restricted from installing a metaport. Instead the metaport should recurse, and its dependents should be accepted or not. |
| Mk/bsd.licenses.db.mk | ||
|---|---|---|
| 404 ↗ | (On Diff #43044) | True. Do you think that the future developers would benefit from adding your explanation to the source code? If so then I'd vote for adding a comment here. |
Comment Actions
In my point of view, the warnings should be fixed instead of having you do stupider things.
There is absolutely no need for a new license. Use the same license as the ports tree, BSD2CLAUSE.
Comment Actions
Also, setting LICENSE=BSD2CLAUSE in metaport.mk works, bsd.licenses.mk is included late in the process.
Comment Actions
Are you sure. Diff is from before your change:
Index: Mk/Uses/metaport.mk =================================================================== --- Mk/Uses/metaport.mk (revision 470958) +++ Mk/Uses/metaport.mk (working copy) @@ -17,5 +17,6 @@ NO_BUILD= yes NO_INSTALL= yes NO_MTREE= yes NO_ARCH= yes +LICENSE= BSD2CLAUSE .endif
∴make -C x11/xorg-minimal -VLICENSE
BSD2CLAUSE
∴make -C x11/xorg-minimal /!\ xorg-minimal-7.5.2_1: Makefile warnings, please consider fixing /!\ Please set LICENSE for this port
Comment Actions
I said it works, as in, it gives the license to the port. I never said anything about any warning.