Page MenuHomeFreeBSD
Differential D15500

Add Warsaw user group.
ClosedPublic
Actions

Authored by oshogbo on May 20 2018, 12:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 26, 6:51 AM
Unknown Object (File)
Wed, Nov 26, 12:15 AM
Unknown Object (File)
Tue, Nov 25, 10:47 PM
Unknown Object (File)
Wed, Nov 19, 1:24 PM
Unknown Object (File)
Tue, Nov 18, 3:12 PM
Unknown Object (File)
Tue, Nov 18, 1:58 PM
Unknown Object (File)
Tue, Nov 18, 1:58 PM
Unknown Object (File)
Tue, Nov 18, 1:58 PM
View All 86 Files
Subscribers
None

Details

Reviewers
allanjude
bcr
Commits
rD51702: Add Warsaw, Poland user group.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

oshogbo created this revision.May 20 2018, 12:38 PM
bcr added a comment.May 20 2018, 1:17 PM

Two comments, minor things, easy to fix.

share/xml/usergroups.xml
443

Are you sure you need the // at the end of the URL? ;-)

444

You need to wrap this line at 75 characters. Compare the indentation below the <description> part with the other entries in this file.

oshogbo updated this revision to Diff 42766.May 20 2018, 1:51 PM

Thank you bcr@ .

oshogbo added a comment.May 22 2018, 7:16 AM

Ping :)

bcr accepted this revision.May 22 2018, 7:20 AM

From what I can tell, the indentation of "family" should start below the 'e' of <description>.

The rest is fine, so you have my permission to commit when you've fixed that.

This revision is now accepted and ready to land.May 22 2018, 7:20 AM
Closed by commit rD51702: Add Warsaw, Poland user group. (authored by oshogbo). · Explain WhyMay 22 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.
oshogbo added a comment.May 22 2018, 7:30 AM

Aghr! ;/ Sorry and thank you @bcr

Revision Contents
Changeset List

PathSize
share/
xml/
12 lines

Diff 42766

View Options

share/xml/usergroups.xml

Loading...