Page MenuHomeFreeBSD
Differential D15492

Add support for the XIVE XICS emulation mode for POWER9 systems
ClosedPublic
Actions

Authored by jhibbits on May 19 2018, 7:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 9:15 AM
Unknown Object (File)
Oct 18 2024, 7:53 AM
Unknown Object (File)
Oct 18 2024, 7:53 AM
Unknown Object (File)
Oct 18 2024, 7:53 AM
Unknown Object (File)
Oct 18 2024, 7:53 AM
Unknown Object (File)
Oct 18 2024, 7:52 AM
Unknown Object (File)
Oct 18 2024, 7:52 AM
Unknown Object (File)
Oct 18 2024, 7:52 AM
View All 99 Files
Subscribers
imp

Details

Reviewers
nwhitehorn
breno.leitao_gmail.com
Commits
rS333912: Add support for the XIVE XICS emulation mode for POWER9 systems
Summary

POWER9 systems use a new interrupt controller, XIVE, managed through OPAL
firmware calls. The OPAL firmware includes support for emulating the previous
generation XICS presentation layer in addition to a new "XIVE Exploitation"
mode. As a stopgap until we have XIVE exploitation mode, enable XICS emulation
mode so that we at least have an interrupt controller.

Since the CPPR is local to the current CPU, it cannot be updated for APs when
initializing on the BSP. This adds a new function, directly called by the
powernv platform code, to initialize the CPPR on AP bringup.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhibbits created this revision.May 19 2018, 7:58 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 19 2018, 7:58 PM
Harbormaster completed remote builds in B16703: Diff 42743.May 19 2018, 7:58 PM
nwhitehorn added inline comments.May 19 2018, 8:40 PM
sys/powerpc/aim/mp_cpudep.c
99 ↗(On Diff #42743)

HVICE is a reserved bit on POWER8 (ISA 2.07) and should be set only on POWER9 (Power ISA 3+). This should probably be some switch on the ISA version from CPU features rather than the PVR, anyway.

406 ↗(On Diff #42743)

Ditto here with respect to POWER8.

sys/powerpc/include/spr.h
238 ↗(On Diff #42743)

Note that this is only in ISA >= 3?

sys/powerpc/powernv/platform_powernv.c
156 ↗(On Diff #42743)

See: POWER ISA 3 comments.

465 ↗(On Diff #42743)

This method is called only on APs, so no need for this if.

466 ↗(On Diff #42743)

Why not do this inline? I assume this whole mode will be removed once XIVE support lands.

sys/powerpc/pseries/xics.c
563 ↗(On Diff #42743)

This is guaranteed to the be the root PIC. Why not rely on that?

jhibbits added inline comments.May 20 2018, 12:52 AM
sys/powerpc/aim/mp_cpudep.c
99 ↗(On Diff #42743)

Easy enough to address. I'll set up a 'lpcr' variable at platform init time appropriate for the CPU (can use cpu_featuers at this point, since it's initialized much earlier than platform)

sys/powerpc/include/spr.h
238 ↗(On Diff #42743)

Can do, will do

sys/powerpc/pseries/xics.c
563 ↗(On Diff #42743)

True, I could do that. I went this route as a sort of seatbelt, but it's probably overkill.

jhibbits updated this revision to Diff 42751.May 20 2018, 2:00 AM

Address Nathan's comments

  • Use root_pic instead of locally stored PIC reference.
  • Create a lpcr variable to hold the LPCR config, which is different from 2.0x and 3.0.
Harbormaster completed remote builds in B16709: Diff 42751.May 20 2018, 2:00 AM
nwhitehorn added a comment.May 20 2018, 2:03 AM

See the comment on line 467 about powernv_smp_ap_init(). Otherwise, looks good.

sys/powerpc/powernv/platform_powernv.c
157 ↗(On Diff #42751)

Shouldn't this be earlier/elsewhere? It's not exactly PowerNV specific (insofar as PowerNV means "opal + FDT"). This is not a blocking comment, though.

jhibbits updated this revision to Diff 42752.May 20 2018, 2:38 AM

Check the BSP by first getting the BSP, rather than relying on special knowledge.

Harbormaster completed remote builds in B16710: Diff 42752.May 20 2018, 2:38 AM
nwhitehorn added inline comments.May 20 2018, 2:50 AM
sys/powerpc/powernv/platform_powernv.c
157 ↗(On Diff #42752)

This double-sets LPCR_HVICE.

470 ↗(On Diff #42752)

This doesn't work. PCPU fields aren't set until after this function is called on the BSP.

jhibbits updated this revision to Diff 42753.May 20 2018, 3:07 AM

Address further comments

Harbormaster completed remote builds in B16711: Diff 42753.May 20 2018, 3:07 AM
jhibbits updated this revision to Diff 42754.May 20 2018, 3:17 AM

Delete unnecessary bits

Harbormaster completed remote builds in B16712: Diff 42754.May 20 2018, 3:17 AM
nwhitehorn accepted this revision.May 20 2018, 3:21 AM
This revision is now accepted and ready to land.May 20 2018, 3:21 AM
Closed by commit rS333912: Add support for the XIVE XICS emulation mode for POWER9 systems (authored by jhibbits). · Explain WhyMay 20 2018, 3:23 AM
This revision was automatically updated to reflect the committed changes.
jhibbits mentioned this in D15331: Enable XIVE XICS emulation mode for POWER9 interrupt controller.May 20 2018, 4:01 AM

Revision Contents
Changeset List

PathSize
head/
sys/
powerpc/
aim/
4 lines
include/
1 line
17 lines
powernv/
5 lines
11 lines
powerpc/
4 lines
pseries/
114 lines

Diff 42755

View Options

head/sys/powerpc/aim/mp_cpudep.c

Loading...
View Options

head/sys/powerpc/include/cpu.h

Loading...
View Options

head/sys/powerpc/include/spr.h

Loading...
View Options

head/sys/powerpc/powernv/opal.h

Loading...
View Options

head/sys/powerpc/powernv/platform_powernv.c

Loading...
View Options

head/sys/powerpc/powerpc/cpu.c

Loading...
View Options

head/sys/powerpc/pseries/xics.c

Loading...