Page MenuHomeFreeBSD
Differential D1543

crunchide: Correct 64-bit section header offset
ClosedPublic
Actions

Authored by emaste on Jan 16 2015, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 10:10 PM
Unknown Object (File)
Thu, Dec 5, 11:27 PM
Unknown Object (File)
Oct 2 2024, 8:32 AM
Unknown Object (File)
Sep 27 2024, 6:50 AM
Unknown Object (File)
Sep 21 2024, 5:27 AM
Unknown Object (File)
Aug 29 2024, 4:27 AM
Unknown Object (File)
Aug 29 2024, 4:27 AM
Unknown Object (File)
Aug 29 2024, 3:52 AM
View All 90 Files
Subscribers
freebsd-toolchain-list
Tokens
"Like" token, awarded by pfg.

Details

Reviewers
pfg
imp
Summary

For 64-bit binaries the Elf_Ehdr e_shoff is at offset 40, not 44. Instead of using an incorrect hardcoded offset, let the compiler figure it out for us with offsetof().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 3210.Jan 16 2015, 4:29 PM
emaste retitled this revision from to crunchide: Correct 64-bit section header offset.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a subscriber: Unknown Object (MLST).
emaste added a reviewer: pfg.Jan 16 2015, 6:34 PM
imp accepted this revision.Jan 16 2015, 6:48 PM
imp added a reviewer: imp.
This revision is now accepted and ready to land.Jan 16 2015, 6:48 PM
emaste closed this revision.Jan 16 2015, 7:00 PM

Committed as rS277259

pfg edited edge metadata.Jan 17 2015, 1:31 AM

Nice, thanks! FWIW, I meant to approve it you guys beat me ;).

pfg awarded a token.Jan 17 2015, 1:31 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
crunch/
crunchide/
3 lines

Diff 3210

View Options

usr.sbin/crunch/crunchide/exec_elf32.c

Loading...