Page MenuHomeFreeBSD

Mk/bsd.sanity.mk: mark WITH_HTTP(S)_PORT notneeded
Needs ReviewPublic

Authored by brnrd on May 13 2018, 9:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 23 2023, 2:43 AM
Unknown Object (File)
Aug 27 2023, 6:52 AM
Unknown Object (File)
Aug 14 2023, 1:00 AM
Unknown Object (File)
Aug 13 2023, 6:13 AM
Unknown Object (File)
Jun 18 2023, 1:49 PM
Unknown Object (File)
May 7 2023, 2:34 AM
Unknown Object (File)
Jan 22 2023, 10:00 AM
Unknown Object (File)
Jan 16 2023, 6:42 AM
Subscribers

Details

Reviewers
joneum
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary
Mk/bsd.sanity.mk: mark WITH_HTTP(S)_PORT notneeded

 - No ports use WITH_HTTP(S)_PORT

Depends on: https://reviews.freebsd.org/D15411
Depends on: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228212

The only 2 ports that use WITH_HTTP_PORT and WITH_HTTPS_PORT are
www/apache24 and security/axTLS.
For www/apache24 this no longer makes sense, the listening port is
defined in the apache24/httpd.conf and apache24/extra/httpd-ssl.conf
files.
For security/axTLS the variables are not used anywhere in the source
or SUB_FILES.

Does this deserve an entry in UPDATING so it doesn't trip up people
using WITH_HTTP_PORT for www/apache24?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 16554
Build 16468: arc lint + arc unit

Event Timeline

Did it have an effect before it was removed?
Because the message is quite obscure.

In D15412#347910, @mat wrote:

Did it have an effect before it was removed?

For security/axTLS it looks like it set the default https port. Probably I should include changes to that port here. Will contact maintainer.
For www/apache24 it has already been removed.

In D15412#347910, @mat wrote:

Because the message is quite obscure.

Agree that this is an obscure message, verbatim copy from other messages.

From: brnrd@FreeBSD.org
To: umq@ueo.co.jp
CC: mat@FreeBSD.org
Subject: security/axTLSL: Removal of WITH_HTTP(S)_PORT

Hi,

I'm contacting you as maintainer of the axTLS port.

A while ago I created a change for the WITH_HTTP(S)_PORT variable that is used in the port
https://reviews.freebsd.org/D15412

Can you please let me know if you see any problems with this change? The axTLS port is the only remaining user of the WITH_HTTP(S)_PORT variables in the ports tree.

On another note, I see at https://sourceforge.net/projects/axtls/files/ that 12 subsequent releases are available for axTLS, perhaps it is time to update the port (1.4.9 was released Januari 2013)?

With kind regards,

Bernard Spil.