DTrace modules for FreeBSD dwatch(1) to produce gource logs
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 16561 Build 16475: arc lint + arc unit
Event Timeline
sysutils/dwatch-gource/Makefile | ||
---|---|---|
22 | To use PORTDOCS, you must have a DOCS option. |
Comment Actions
Looks good to me. I don't understand mat@'s comment. It looks stale, but if not my approval is contingent on you resolving it.
sysutils/dwatch-gource/Makefile | ||
---|---|---|
22 | Good catch. I copied a port that had a DOCS option. I'll remove this line. |
sysutils/dwatch-gource/Makefile | ||
---|---|---|
21–22 | You are installing some doc, which is not reflected in the plist, I doubt the framework did not say anything about a file missing. If you install some doc, you must add a DOCS option, and either use the PORTDOCS macro or add the file to the plist guarded with the %%PORTDOCS%% macro. |
Comment Actions
Put "FreeBSD" at the beginning of COMMENT to make portlint happy
portlint didn't like "dwatch" at start and can't just capitalize
the name of a utility to satisfy it, but this makes it happy.