Upgrade gravitational teleport to 2.6.6.
Explicitly specify the git sha when building teleport. Restrict builds to amd64.
Details
Details
doas poudriere testport -j 12amd64 -o security/teleport -p dev
Result is clean.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
You need to bump PORTREVISION.
Also, could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
Comment Actions
Upgrade gravitational teleport to 2.5.7.
Explicitly specify the git sha when building teleport. Restrict builds to amd64.
| head/security/teleport/Makefile | ||
|---|---|---|
| 13 ↗ | (On Diff #42431) | Please add ONLY_FOR_ARCHS_REASON to explain. |
| 15–16 ↗ | (On Diff #42431) | Remove ${LOCALBASE}/bin/. |
| 22 ↗ | (On Diff #42431) | Remove, default. |
| 32 ↗ | (On Diff #42431) | Use @sample? |
| 34 ↗ | (On Diff #42431) | Why? |
| 45 ↗ | (On Diff #42431) | It would probably be easier to simply do something like: 's|^GITREF=.*|GITREF=${GH_TAG_COMMIT}|'and remove the patch. |
| 52 ↗ | (On Diff #42431) | Remove -s, builds must not be silent. |
Comment Actions
Updated port with feedback from @mat
| head/security/teleport/Makefile | ||
|---|---|---|
| 15–16 ↗ | (On Diff #42431) | I looked for a way to see if there is a test to verify that a version of go is greater than a given version. If a user only has go1.4 in their path then the build will fail, whereas using ${LOCALBASE}/bin implies someone is keeping current with their ports maintenance. I've made the adjustment, but that's why I used ${LOCALBASE}/bin. |
| 34 ↗ | (On Diff #42431) | The teleport binary includes extra UI elements appended to the binary that is removed when the binary is stripped. |
Comment Actions
Could you use devel/arcanist, or at least generate a diff with full context like it does, with svn diff -x -U9999 or git diff -U9999.
| head/security/teleport/Makefile | ||
|---|---|---|
| 15–16 ↗ | (On Diff #42431) | I don't understand. If you remove ${LOCALBASE}/bin/ as I asked, the framework will look for a binary named go in PATH. If a user has a go14 binary, well, it will not be used, as it is not called go. Please remove ${LOCALBASE}/bin/. |
| 34 ↗ | (On Diff #42431) | Then please add a comment before the STRIP variable saying so. |
| head/security/teleport/Makefile | ||
|---|---|---|
| 15–16 ↗ | (On Diff #42431) | I understand. My comment is with regards to common development patterns where ~/go/bin/go may not be the latest and greatest and may not meet the build requirements. It's common to use PATH=$GOPATH/bin:$PATH which means a user's local go would be used. I was trying to guard against that particular outcome. I fixed it in the patch but was explaining why I used ${LOCALBASE}/bin/go vs just go. |
Comment Actions
Mmmm, right, but I really do not feel this edge case needs to be addressed, packages are supposed to be built in a clean environment in poudriere/synth, or as root, I think it's safe to assume that there will not be a ~root/.../go.
Comment Actions
Agreed, and I have already removed ${LOCALBASE}/bin/go from BUILD_DEPENDS - I wasn't arguing with you, I was only explaining why I added it in the first place. :)
Comment Actions
Incorporate @swills' feedback. Work around daemon(8)'s lack of syslog functionality in 10-STABLE.