Page MenuHomeFreeBSD

biology/ddocent: Bash pipeline for RAD sequencing
ClosedPublic

Authored by jwb on Apr 20 2018, 12:32 AM.

Details

Summary

biology/ddocent: Bash pipeline for RAD sequencing
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message

This is the culmination of all the commits I've done over the past few weeks!

Test Plan

portlint -AC: looks fine
Passed poudriere on {10.3,11.1}-{amd64,i386}
Tested in production

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

biology/ddocent/Makefile
3 ↗(On Diff #41670)

Case doesn't match entry in biology/Makefile

41 ↗(On Diff #41670)

NO_ARCH=yes ?

46 ↗(On Diff #41670)

I recall being asked to switch this to the post-install, but I don't recall why. Sorry, not very helpful, but if you are motivated you could dig. ..up to you.

biology/ddocent/Makefile
3 ↗(On Diff #41670)

make -C/usr/ports/biolog checksubdirs is helpful for this.

I think biology/Makefile should match the directory name, not PKGBASE.

Good catch on NO_ARCH. I tried this one without using my checklist and
proved I'm not quite ready. ;-)

I'll trust your memory on the post-install.

Thanks...

In D15139#318984, @jwb wrote:

I think biology/Makefile should match the directory name, not PKGBASE.

Oh, of course. I recalling our long discussion about case, so I will stop making suggestions on this.

This revision is now accepted and ready to land.Apr 20 2018, 1:20 AM

Don't stop making suggestions until I stop making mistakes. ;-)

This revision was automatically updated to reflect the committed changes.