Page MenuHomeFreeBSD

loader: cstyle cleanup of command.c
ClosedPublic

Authored by tsoome on Apr 16 2018, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 6:18 AM
Unknown Object (File)
Nov 18 2024, 11:00 AM
Unknown Object (File)
Nov 17 2024, 5:43 PM
Unknown Object (File)
Nov 11 2024, 2:55 PM
Unknown Object (File)
Nov 11 2024, 7:47 AM
Unknown Object (File)
Nov 11 2024, 4:24 AM
Unknown Object (File)
Nov 11 2024, 12:46 AM
Unknown Object (File)
Nov 10 2024, 11:54 PM
Subscribers
None

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16162
Build 16115: arc lint + arc unit

Event Timeline

OK. Tagged a bunch of excess parens lines. Since you're doing style changes, you might want to consider doing them now. They aren't any more wrong now than they were before, though, so I'd understand if you didn't want to risk it if you'd extensively tested these changes.

stand/common/commands.c
74โ€“100

still has excess parens.

78

excess parens

80

excess parens

84

excess parens

181โ€“182

excess parens

185

excess parens

192

excess parens

243

excess parens

This revision is now accepted and ready to land.Apr 16 2018, 1:29 PM
tsoome marked 8 inline comments as done.

remove excess parens

This revision now requires review to proceed.Apr 16 2018, 1:58 PM

my eyeballs say that the excess paren stuff is good now. Thanks!

This revision is now accepted and ready to land.Apr 16 2018, 2:03 PM
This revision was automatically updated to reflect the committed changes.