loader: cstyle cleanup of command.c
ClosedPublic
Actions

Authored by tsoome on Apr 16 2018, 12:50 PM.

Details

Reviewers

bapt
imp

Commits

rS332565: loader: cstyle cleanup of command.c

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Apr 16 2018, 12:50 PM

Harbormaster completed remote builds in B16160: Diff 41509.Apr 16 2018, 12:50 PM

OK. Tagged a bunch of excess parens lines. Since you're doing style changes, you might want to consider doing them now. They aren't any more wrong now than they were before, though, so I'd understand if you didn't want to risk it if you'd extensively tested these changes.

stand/common/commands.c
74 ↗	(On Diff #41509)	still has excess parens.
78 ↗	(On Diff #41509)	excess parens
80 ↗	(On Diff #41509)	excess parens
84 ↗	(On Diff #41509)	excess parens
181–182 ↗	(On Diff #41509)	excess parens
185 ↗	(On Diff #41509)	excess parens
192 ↗	(On Diff #41509)	excess parens
243 ↗	(On Diff #41509)	excess parens

This revision is now accepted and ready to land.Apr 16 2018, 1:29 PM

remove excess parens

This revision now requires review to proceed.Apr 16 2018, 1:58 PM

Harbormaster completed remote builds in B16162: Diff 41522.Apr 16 2018, 1:58 PM

removed parens.

my eyeballs say that the excess paren stuff is good now. Thanks!

This revision is now accepted and ready to land.Apr 16 2018, 2:03 PM

Closed by commit rS332565: loader: cstyle cleanup of command.c (authored by tsoome). · Explain WhyApr 16 2018, 2:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

common/

commands.c

644 lines

Diff 41524

View Options

head/stand/common/commands.c

loader: cstyle cleanup of command.cClosedPublicActions