Boot with msk(4), bge(4).
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Add mii_phy_mac_softc()/mii_dev_mac_softc() to get softc of the NIC w/o
going through ifnet(9) layer. Used in brgphy.c
Updating D1506: Use device_get_parent() to get hint on the NIC instead of going
over ifnet(9) layer.
Comment Actions
Just some minor nits. Looks good in terms of the overall change.
| sys/dev/mii/mii.c | ||
|---|---|---|
| 653 | I prefer "strcmp(foo, bar) == 0" to "!strcmp" since at a higher level it is checking for equality, so nice to see the "==" in the test. | |
| sys/dev/mii/miivar.h | ||
| 268 | I think in style(9) the '*' is put at the start of the function name, so 'void<tab>*mii_...' rather than 'void *<tab>mii_...' | |
Comment Actions
Address John's comments.
Updating D1506: Use device_get_parent() to get hint on the NIC instead of going
over ifnet(9) layer.