Page MenuHomeFreeBSD

Use device_get_parent() to get hint on the NIC instead of going over ifnet(9) layer.
ClosedPublic

Authored by glebius on Jan 12 2015, 9:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 20 2026, 1:04 PM
Unknown Object (File)
Jan 20 2026, 12:15 PM
Unknown Object (File)
Jan 19 2026, 7:23 PM
Unknown Object (File)
Jan 17 2026, 6:31 PM
Unknown Object (File)
Dec 21 2025, 8:34 AM
Unknown Object (File)
Nov 12 2025, 6:52 AM
Unknown Object (File)
Nov 7 2025, 8:00 AM
Unknown Object (File)
Nov 7 2025, 8:00 AM
Subscribers
None

Details

Reviewers
jhb
glebius
imp
Test Plan

Boot with msk(4), bge(4).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

glebius retitled this revision from to Use device_get_parent() to get hint on the NIC instead of going over ifnet(9) layer..
glebius updated this object.
glebius edited the test plan for this revision. (Show Details)
glebius added reviewers: jhb, imp.
imp edited edge metadata.
This revision is now accepted and ready to land.Jan 12 2015, 9:21 PM
glebius edited edge metadata.

Add mii_phy_mac_softc()/mii_dev_mac_softc() to get softc of the NIC w/o
going through ifnet(9) layer. Used in brgphy.c

Updating D1506: Use device_get_parent() to get hint on the NIC instead of going

over ifnet(9) layer.

This revision now requires review to proceed.Jan 12 2015, 10:06 PM

Just some minor nits. Looks good in terms of the overall change.

sys/dev/mii/mii.c
653

I prefer "strcmp(foo, bar) == 0" to "!strcmp" since at a higher level it is checking for equality, so nice to see the "==" in the test.

sys/dev/mii/miivar.h
268

I think in style(9) the '*' is put at the start of the function name, so 'void<tab>*mii_...' rather than 'void *<tab>mii_...'

glebius edited edge metadata.

Address John's comments.

Updating D1506: Use device_get_parent() to get hint on the NIC instead of going

over ifnet(9) layer.

This revision is now accepted and ready to land.Jan 12 2015, 10:28 PM