Page MenuHomeFreeBSD

Introduce ofw_bus_reg_to_rl() to replace part of common bus code
ClosedPublic

Authored by zbb on Jan 12 2015, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 10:37 AM
Unknown Object (File)
Mon, Oct 21, 6:40 AM
Unknown Object (File)
Thu, Oct 17, 11:26 PM
Unknown Object (File)
Oct 3 2024, 8:09 PM
Unknown Object (File)
Oct 2 2024, 12:36 PM
Unknown Object (File)
Sep 28 2024, 10:58 AM
Unknown Object (File)
Sep 24 2024, 8:58 AM
Unknown Object (File)
Sep 22 2024, 9:08 AM
Subscribers

Details

Summary

Instead of reusing the same reg parsing code, create one, common function that puts reg contents to the resource list.
Address cells and size cells are passed rather than acquired here so that any bus can have different default values.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zbb retitled this revision from to Introduce ofw_bus_reg_to_rl() to replace part of common bus code.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: nwhitehorn, ian, andrew.
ian edited edge metadata.

thanks for doing this, I meant to do it after I did the intr_to_rl, and just forgot.

sys/dev/ofw/ofw_bus_subr.c
412

this is passing uint64_t values to an api that takes 32-bit values on some arches, we'll probably need to cast to u_long to avoid warnings. hmm, then again maybe not, I guess the old code was the same.

This revision is now accepted and ready to land.Jan 12 2015, 7:41 PM
nwhitehorn edited edge metadata.

Looks good to me.

Thanks.

Committed to r277098