Page MenuHomeFreeBSD

New ports required for gitlab 10.6.x.
ClosedPublic

Authored by mfechner on Apr 10 2018, 9:09 PM.

Details

Summary

I copied the directories using "svn copy initialport@revision newport" modified the required lines and added the port to ../Makefile.

Commit message:
Added new ports required for gitlab 10.6.x.

Reviewed by: tz/swills (mentor)
Approved by: tz/swills (mentor)
Differential Revision: URL to this revision

Test Plan

All patches are build, you can find all build logs:
https://pkg.fechner.net/jail.html?mastername=111amd64-gitlab

The fresh packages are tested against a new installation using:
https://gitlab.fechner.net/mfechner/Gitlab-vagrant

An old version is updated following the manual:
https://gitlab.fechner.net/mfechner/Gitlab-docu

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

textproc/rubygem-github-linguist53/Makefile
19 ↗(On Diff #41345)

Confused by this, why?

mfechner added inline comments.
textproc/rubygem-github-linguist53/Makefile
19 ↗(On Diff #41345)

Without this line you get a stage fail with poudriere which complains about that this line is missing.

Here the build log with the line missing:
https://pkg.fechner.net/data/111amd64-gitlab/2018-04-10_16h50m00s/logs/rubygem-github-linguist53-5.3.3.log

textproc/rubygem-github-linguist53/Makefile
19 ↗(On Diff #41345)

This is an artefact of the fact that ruby is linked with libunwind on amd64 and i386.

Please do not add a direct dependency on libunwind.

mfechner added inline comments.
textproc/rubygem-github-linguist53/Makefile
19 ↗(On Diff #41345)

Thanks for this information, I removed the dependency.
Should that be addressed as a PR for poudriere?

mfechner marked an inline comment as done.

Removed libunwind and fixed version for rubygem-toml-rb.

textproc/rubygem-github-linguist53/Makefile
19 ↗(On Diff #41345)

It is not a poudriere issue at all. All poudriere does is build packages in a clean environement. An issue in poudriere would be poudriere crashing while you build something :-)

This is a framework issue, the qa check that tells you to add the LIB_DEPENDS is the proxydeps check from Mk/Scripts/qa.sh.

I am unsure how to address the problem, I'll have to think about it a bit.

This revision is now accepted and ready to land.Apr 12 2018, 6:44 PM
This revision was automatically updated to reflect the committed changes.