lang/rust: Update to 1.25
AbandonedPublic
Actions

Authored by bdrewery on Apr 1 2018, 12:10 PM.

Details

Reviewers

jbeich
dumbbell
riggs

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15913
Build 15905: arc lint + arc unit

Event Timeline

riggs created this revision.Apr 1 2018, 12:10 PM

Herald added a subscriber: mat. · View Herald TranscriptApr 1 2018, 12:10 PM

Harbormaster completed remote builds in B15913: Diff 40958.Apr 1 2018, 12:10 PM

riggs added reviewers: jbeich, dumbbell.Apr 1 2018, 12:12 PM

@bdrewery knows what to do with ino64/abstime bits. For one, using freebsd11_* system calls with structs from FreeBSD 12 may not be safe.

lang/rust/distinfo
9	Can you regen aarch64 bootstrap? See `package-to-bootstraps` target. Either test at least `make clean patch ARCH=aarch64` or on ref11-aarch64.freebsd.org.

vishwin added a subscriber: vishwin.Apr 1 2018, 8:12 PM

FWIW, I'm in favor of dropping files/extra-patch-abi. Patching libc/mio/nix crates downstream to support ino64/abstime values is non-trivial as consumers need to be patched as well while mistakes lead to crashes. Depending on COMPAT_FREEBSD11 looks less evil, and FreeBSD 12.0 haven't been released yet.

As Charlie Li confirmed the current version of the patch crashes on FreeBSD 12.0 due to ABI mismatch after 78f93220d70e caused by files/extra-patch-abi.

This revision now requires changes to proceed.Apr 2 2018, 2:05 PM

Looking

bdrewery requested changes to this revision.Apr 2 2018, 5:31 PM

bdrewery added inline comments.

lang/rust/files/extra-patch-abi
1	Why did you rollback this file to the old version? Yes this new patch is wrong. The old patch was correct - and is now upstreamed in this version. The patch can be deleted entirely now.

bdrewery added inline comments.Apr 2 2018, 5:33 PM

lang/rust/files/extra-patch-abi
1	Oh I misread the left side - I didn't copy my upstream patch to lang/rust, only lang/rust-nightly. This patch should just be removed now.

bdrewery added inline comments.Apr 2 2018, 5:36 PM

lang/rust/Makefile
99	The `EXTRA_PATCHES` line can be removed, keep others until the beta is updated to 2018-03-28 probably in 1.26
143	Keep this until probably 1.26 when the beta is updated to 2018-03-18
149	Keep this until probably 1.26 when the beta is updated to 2018-03-18