pmap KBI stable.
ClosedPublic
Actions

Authored by kib on Mar 29 2018, 8:01 PM.

Details

Reviewers

alc
markj

Commits

rS331760: Make vm_map_max/min/pmap KBI stable.

Summary

There are out of tree consumers of vm_map_min() and vm_map_max(), and I believe there are consumers of vm_map_pmap(), although the later is arguably less in the need of KBI-stable interface. For the consumers benefit, make modules using this KPI not depended on the struct vm_map layout.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Mar 29 2018, 8:01 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 29 2018, 8:01 PM

Harbormaster completed remote builds in B15884: Diff 40900.Mar 29 2018, 8:01 PM

markj accepted this revision.Mar 29 2018, 8:28 PM

markj added inline comments.

sys/vm/vm_map.c
4322 ↗	(On Diff #40900)	Shouldn't these routines just call the corresponding inline function?

This revision is now accepted and ready to land.Mar 29 2018, 8:28 PM

kib added inline comments.Mar 29 2018, 8:39 PM

sys/vm/vm_map.c
4322 ↗	(On Diff #40900)	I considered it and my feel was that it would only add an additional layer of obfuscation. I belive we did not make vm_page_*_KBI functions calling non-KBI variants for the same reason.