biology/ncbi-blast+: Upgrade to 2.7.1
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message
Resolves the following PRs:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225002
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226037
Details
- Reviewers
jrm wen - Group Reviewers
O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP465726: biology/ncbi-blast+: Upgrade to 2.7.1
portlint -A: looks fine
Passed poudriere on {10.3,11.1}-{amd64,i386}
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Looks good to me. I wonder if MAKE_JOBS_UNSAFE=yes is warranted? For one poudriere run, I saw all 4 builds (10/11 i386/amd64) fail and there are lots of warnings like this gmake[5]: warning: -jN forced in submake: disabling jobserver mode. http://pkg.awarnach.mathstat.dal.ca/data/11amd64-default/2018-03-26_14h21m50s/logs/errors/ncbi-blast+-2.7.1.log Subsequent builds were fine (I don't think I changed anything). I also tested with MAKE_JOBS_UNSAFE=yes and those warnings went away and it actually built quicker.
That's interesting. I tested with poudriere on a 32-thread machine with no
issues. I saw the warnings, but the builds all succeeded. But, if it built
faster for you with MAKE_JOBS_UNSAFE=yes, it's a moot point.
I'm also removing the empty directories under lib that I overlooked before.
Retesting before I commit, of course.
Mk/bsd.local.mk | ||
---|---|---|
31 ↗ | (On Diff #40761) | This change seems irrelevant to the port. |
Mk/bsd.local.mk | ||
---|---|---|
31 ↗ | (On Diff #40761) | I'm not sure how that got into the diff, arc should have ignored it. At any rate, only the contents of biology/ncbi-blast+ will be committed. |
biology/ncbi-blast+/Makefile | ||
---|---|---|
48 ↗ | (On Diff #40761) | WRKSRC_SUBDIR= c++ |
Switch to WRKSRC_SUBDIR
Patch Makefile.in.top for a cleaner way to support DESTDIR
Please review DESTDIR patch and re-approve
Nothing obvious stands out to me. Are these changes suitable for inclusion upstream?
biology/ncbi-blast+/Makefile | ||
---|---|---|
63 ↗ | (On Diff #40799) | ${RM} includes the -f flag. |