Paths

Table of Contentst

Differential D14818

lualoader: Add cli.lua(8) to the tree
ClosedPublic
Actions

Authored by kevans on Mar 24 2018, 3:47 AM.

Tags

None

Referenced Files

	F170233749: D14818.id.diff
	Thu, Sep 3, 11:28 PM

	Unknown Object (File)
	Wed, Sep 2, 4:32 PM

	Unknown Object (File)
	Tue, Sep 1, 4:47 PM

	Unknown Object (File)
	Tue, Sep 1, 2:55 PM

	Unknown Object (File)
	Tue, Sep 1, 9:46 AM

	Unknown Object (File)
	Tue, Sep 1, 3:23 AM

	Unknown Object (File)
	Mon, Aug 31, 4:27 PM

	Unknown Object (File)
	Sun, Aug 30, 1:53 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS334891: lualoader: Add cli.lua(8) to the tree

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Mar 24 2018, 3:47 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 24 2018, 3:47 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B15759: Diff 40670.Mar 24 2018, 3:47 AM

I'm leaving cli_execute and cli_execute_unparsed undocumented for the time being, since they're:

1.) Kind of special kittens
2.) Actually global
3.) Less stable API

rpokala requested changes to this revision.Jun 8 2018, 3:48 AM

rpokala added inline comments.

stand/lua/cli.lua.8
5 ↗	(On Diff #40670)	Per discussions over the last few months, remove "All rights reserved."
38 ↗	(On Diff #40670)	"... commands, which can be executed at ..."
59 ↗	(On Diff #40670)	s/of/off/
78 ↗	(On Diff #40670)	The example function is `cli.foo`, but this says `Foo` -- capitalized. Is that intended?
96 ↗	(On Diff #40670)	This `-width` value looks like a holdover from another manpage that you derived this from.

This revision now requires changes to proceed.Jun 8 2018, 3:48 AM

I believe I've addressed your latest concerns. =)

Harbormaster completed remote builds in B17114: Diff 43491.Jun 9 2018, 2:30 PM

rpokala accepted this revision as: rpokala.Jun 9 2018, 6:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2018, 7:51 PM

Closed by commit rS334891: lualoader: Add cli.lua(8) to the tree (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

lua/

112 lines

Diff 43515

head/stand/lua/cli.lua.8

Loading...