Add proper UEFI El Torito support to makefs.

[benno]

Summary

We've been marking our UEFI boot image as i386 which, while it seems to work, is not technically correct. This patch adds the correct UEFI system type and marks our amd64 images' EFI boot image correctly.

Test Plan

Test booted the resulting ISO image successfully.

Before:

$ xorriso -indev ../bootonly.iso -report_el_torito plain -report_system_area plain
xorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.

[...]

El Torito catalog  : 19  1
El Torito images   :   N  Pltf  B   Emul  Ld_seg  Hdpt  Ldsiz         LBA
El Torito boot img :   1  BIOS  y   none  0x0000  0x00      4          20
El Torito boot img :   2  BIOS  y   none  0x0000  0x00   1600          24

[...]

After:

$ xorriso -indev ~/freebsd/bootonly.iso -report_el_torito plain -report_system_area plain
xorriso 1.4.8 : RockRidge filesystem manipulator, libburnia project.

[...]

El Torito catalog  : 19  1
El Torito images   :   N  Pltf  B   Emul  Ld_seg  Hdpt  Ldsiz         LBA
El Torito boot img :   1  BIOS  y   none  0x0000  0x00      4          20
El Torito boot img :   2  UEFI  y   none  0x0000  0x00   1600          24

[...]

[benno]

-U9999 per request

[imp]

pure comic sans gold.

[emaste]

usr.sbin/makefs/cd9660/cd9660_eltorito.c

107

Note that we call the partition type "EFI" in mkimg, see rS276893.

Does El-Torito already refer to this as UEFI? Either way we might want to accept both variants?

[benno]

Add efi as a synonym for uefi.

[imp]

release/amd64/mkisoimages.sh

41

s/uefi/efi/ here.

usr.sbin/makefs/cd9660/cd9660_eltorito.c

111

my turn to quibble. All the FreeBSD utilities but one prefer the efi name over the uefi. we should do that here and fix "above"

[benno]

Prefer efi to uefi and properly sort system names in error message.

[imp]

I'm happy again.

[emaste]

fine with me