Details
- Reviewers
• hselasky markj - Commits
- rS331433: linuxkpi whitespace cleanup
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Looks ok to me. I pointed out a bunch of style bugs in the modified lines, but if you prefer to just commit the mechanical change it's ok to ignore me. I'd like the linuxkpi to follow style(9) more carefully.
| sys/compat/linuxkpi/common/include/linux/device.h | ||
|---|---|---|
| 536 ↗ | (On Diff #40637) | Looks like there's an extra tab here. |
| sys/compat/linuxkpi/common/include/linux/jiffies.h | ||
| 41 ↗ | (On Diff #40637) | There should be a tab after #define. |
| sys/compat/linuxkpi/common/include/linux/kobject.h | ||
| 72 ↗ | (On Diff #40637) | Continuing lines should be indented by four spaces. |
| sys/compat/linuxkpi/common/include/linux/list.h | ||
| 170 ↗ | (On Diff #40637) | There should be a tab after #define. |
| 438 ↗ | (On Diff #40637) | While here you could add parens. |
| sys/compat/linuxkpi/common/include/linux/pci.h | ||
| 470 ↗ | (On Diff #40637) | Add parens? Ditto below. |
| 686 ↗ | (On Diff #40637) | Should be indented by four spaces. |
| 748 ↗ | (On Diff #40637) | The indentation is wrong, ditto in pcie_cap_has_rtctl(). |
| 831 ↗ | (On Diff #40637) | Parens? |
| sys/compat/linuxkpi/common/include/linux/usb.h | ||
| 68 ↗ | (On Diff #40637) | The whitespace still looks weird here, but that might just be an artifact of phabricator. |
| sys/compat/linuxkpi/common/include/net/ipv6.h | ||
| 67 ↗ | (On Diff #40637) | Wrong indentation. |
There are currently no big changes pending.
Make sure you MFC these changes to 11-stable aswell.
Feel free to fix simple style issues in the lines you are touching.
| sys/compat/linuxkpi/common/include/linux/list.h | ||
|---|---|---|
| 438 ↗ | (On Diff #40637) | I left these for now as Linuxulator appears to be mostly paren-less return style; most likely the whole thing should be done in one commit. |