Drop KTR_CONTENTION.
ClosedPublic
Actions

Authored by markj on Mar 20 2018, 3:16 PM.

Tags

None

Referenced Files

	F168569623: D14771.diff
	Sat, Aug 29, 1:56 AM

	Unknown Object (File)
	Fri, Aug 28, 4:54 PM

	Unknown Object (File)
	Thu, Aug 27, 10:26 PM

	Unknown Object (File)
	Mon, Aug 24, 1:15 AM

	Unknown Object (File)
	Sat, Aug 22, 8:15 AM

	Unknown Object (File)
	Thu, Aug 20, 8:13 PM

	Unknown Object (File)
	Thu, Aug 20, 8:12 PM

	Unknown Object (File)
	Thu, Aug 20, 8:11 PM

View All Files

Subscribers

imp

Details

Reviewers

jhb
mjg

Commits

rS331245: Drop KTR_CONTENTION.

Summary

It is incomplete, has not been adopted in the other locking primitives,
and we have other means of measuring lock contention (lock_profiling,
lockstat, KTR_LOCK). Drop it to slightly de-clutter the mutex code and
free up a precious KTR class index.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 20 2018, 3:16 PM

Harbormaster completed remote builds in B15663: Diff 40499.Mar 20 2018, 3:16 PM

markj added reviewers: jhb, mjg.Mar 20 2018, 3:17 PM

the less ktr the better

This revision is now accepted and ready to land.Mar 20 2018, 3:26 PM

I think this is fine.

Closed by commit rS331245: Drop KTR_CONTENTION. (authored by markj). · Explain WhyMar 20 2018, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2018, 3:51 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

kern_mutex.c

21 lines

sys/

ktr_class.h

2 lines

Diff 40503

View Options

head/sys/kern/kern_mutex.c