Improve hostid handling.

[delphij]

Summary

• Always update hostid file in hostid_save when it does not match record.
• Generate uuid when the system UUID is known bad or malformed. A known bad blacklist is included.
• Quote ${uuid} in [ context.

[emaste]

etc/rc.d/hostid

58

Probably worth a comment explaining where some of the invalid ones come from. I can see how all-zeros might happen and some of them are obviously manually entered dummy values. It isn't clear where some of them come from, such as 8e275844-178f.... Presumably these have been observed in the field from various manufacturers with broken schemes.

Googling found a list at https://capawiki.capasystems.com/display/CI51DOC/Non-Unique+UUID, which has some other entries not included here.

[delphij]

In D1476#4, @emaste wrote:

Probably worth a comment explaining where some of the invalid ones come from. I can see how all-zeros might happen and some of them are obviously manually entered dummy values. It isn't clear where some of them come from, such as 8e275844-178f.... Presumably these have been observed in the field from various manufacturers with broken schemes.

Googling found a list at https://capawiki.capasystems.com/display/CI51DOC/Non-Unique+UUID, which has some other entries not included here.

I have used xargs with the extracted valid_hostid and simple script (if valid_hostid $1; then echo $1; fi) and verified that the IDs listed on that page are all covered.

I'm not sure if we can get an exhaustive list (e.g. some of the blacklisted IDs are seen on hardware that we sell) but I guess it would be a future thing and having the blacklist as-is is still beneficial.

[delphij]

Closed by rS282114 and rS281565.

[emaste]

In D1476#41729, @delphij wrote:

In D1476#4, @emaste wrote:

Probably worth a comment explaining where some of the invalid ones come from. I can see how all-zeros might happen and some of them are obviously manually entered dummy values. It isn't clear where some of them come from, such as 8e275844-178f.... Presumably these have been observed in the field from various manufacturers with broken schemes.

Googling found a list at https://capawiki.capasystems.com/display/CI51DOC/Non-Unique+UUID, which has some other entries not included here.

I have used xargs with the extracted valid_hostid and simple script (if valid_hostid $1; then echo $1; fi) and verified that the IDs listed on that page are all covered.

Indeed; perhaps I missed that many of the entries there match *-ffff-ffff-ffff-ffffffffffff