Page MenuHomeFreeBSD
Differential D14719

Add missing LIB_DEPENDS as reported in stage-qa
ClosedPublic
Actions

Authored by fernape on Mar 17 2018, 12:01 PM.
Tags
None
Referenced Files
F103175587: D14719.id40521.diff
Thu, Nov 21, 10:03 PM
Unknown Object (File)
Mon, Nov 18, 7:10 AM
Unknown Object (File)
Sun, Nov 17, 4:19 AM
Unknown Object (File)
Sun, Nov 17, 1:48 AM
Unknown Object (File)
Wed, Nov 13, 11:50 AM
Unknown Object (File)
Sun, Nov 10, 2:45 PM
Unknown Object (File)
Sun, Nov 10, 12:13 PM
Unknown Object (File)
Sun, Nov 10, 12:09 PM
View All 70 Files
Subscribers
mat

Details

Reviewers
tz
tcberner
Commits
rP465112: math/dynare: Add missing LIB_DEPENDS to fix stage-qa
Summary

Add missing LIB_DEPENDS as reported in stage-qa

Test Plan

cd math/dynare && portlint -AC && make
It should have a clean output now.

Poudriere logs for {10.3,10.4,11.1}{i386,amd64} and 12i386
https://www.dropbox.com/sh/z0581x5p6opj7vd/AAAUDcCWKUU_5c_hoiki9gGaa?dl=0

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.Mar 17 2018, 12:01 PM
Herald added a subscriber: mat. · View Herald TranscriptMar 17 2018, 12:01 PM
Harbormaster completed remote builds in B15615: Diff 40379.Mar 17 2018, 12:01 PM
fernape edited the test plan for this revision. (Show Details)Mar 17 2018, 12:31 PM
tcberner added inline comments.Mar 17 2018, 4:38 PM
math/dynare/Makefile
24 ↗(On Diff #40379)

There's no need to add it twice.

tcberner added a comment.Mar 17 2018, 4:40 PM

You have an OCTAVE Option already, so is ovtave always required?

fernape updated this revision to Diff 40396.Mar 17 2018, 11:51 PM

Add OCTAVE_LIB_DEPENDS dependency.

Poudriere builds for {10.3,10.4,11.1}{amd64,i386} and 12 i386
available https://www.dropbox.com/sh/nf49c231hdwi08e/AABQ87bkb3ko1U9KplQSXK9aa?dl=0

Harbormaster completed remote builds in B15626: Diff 40396.Mar 17 2018, 11:52 PM
fernape updated this revision to Diff 40397.Mar 17 2018, 11:54 PM

I uploaded by mistake some other files I was working on...

tcberner added inline comments.Mar 18 2018, 6:39 AM
math/dynare/Makefile
22 ↗(On Diff #40397)

^ trailing \

39 ↗(On Diff #40397)

^ you can get rid of the BUILD_DEPENDS as you add the LIB_DEPENDS.

fernape updated this revision to Diff 40411.Mar 18 2018, 4:21 PM

Address both problems.

New logs in https://www.dropbox.com/sh/nws7okkqi69lqg8/AABDld-J-2U6qav1za1zlN00a?dl=0

Harbormaster completed remote builds in B15631: Diff 40411.Mar 18 2018, 4:21 PM
tcberner added inline comments.Mar 18 2018, 9:15 PM
math/dynare/Makefile
38 ↗(On Diff #40411)

^no need for +=

fernape updated this revision to Diff 40441.Mar 19 2018, 4:43 PM

Replace '+=' with '=' in OCTAVE_LIB_DEPENDS

Harbormaster completed remote builds in B15647: Diff 40441.Mar 19 2018, 4:43 PM
tz accepted this revision.Mar 20 2018, 10:19 AM

Looks fine to me

This revision is now accepted and ready to land.Mar 20 2018, 10:19 AM
Closed by commit rP465112: math/dynare: Add missing LIB_DEPENDS to fix stage-qa (authored by fernape). · Explain WhyMar 20 2018, 10:26 PM
This revision was automatically updated to reflect the committed changes.
fernape marked 4 inline comments as done.

Revision Contents
Changeset List

PathSize
head/
math/
dynare/
4 lines

Diff 40521

View Options

head/math/dynare/Makefile

Loading...