Page MenuHomeFreeBSD

Show SSID maximum string length in ifconfig scan
ClosedPublic

Authored by krion on Mar 16 2018, 2:16 PM.

Details

Summary

14 chars length for showing SSIDs is not enough while dealing with
long SSIDs, I think it makes sense to show max SSID length (32
octets).

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

krion created this revision.Mar 16 2018, 2:16 PM
kristof added inline comments.
sbin/ifconfig/ifieee80211.c
3506 ↗(On Diff #40345)

sys/net80211/ieee80211.h defines sys/net80211/ieee80211.h as 32, so this line becomes tautological.

I also worry that this might break scripts/tools that use ifconfig and parse its output.

3506 ↗(On Diff #40345)

Sigh. 'IEEE80211_NWID_LEN' as 32, of course.

krion added a comment.Mar 16 2018, 4:24 PM
sbin/ifconfig/ifieee80211.c
3506 ↗(On Diff #40345)

How can I test it together with scripts/tools?

With an old behavior the output looks like:

SSID/MESH ID
0xc2af5c5f2...
3HuiTube_2....

with 32 chars:

SSID/MESH ID
0xc2af5c5f28e38384
3HuiTube_2.4Ghz_A08A
adrian accepted this revision.Mar 16 2018, 4:29 PM

I think it's fine to extend it; longer SSIDs are now a thing and have been for a while.

This revision is now accepted and ready to land.Mar 16 2018, 4:29 PM
This revision was automatically updated to reflect the committed changes.